Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pass additional arguments to yarn #188

Closed
andreyfel opened this issue Mar 21, 2018 · 4 comments
Closed

Pass additional arguments to yarn #188

andreyfel opened this issue Mar 21, 2018 · 4 comments

Comments

@andreyfel
Copy link

I need to skip optional dependencies on the yarn install phase to reduce time of the build. So, I need to run yarn install with "--ignore-optional" argument.
Generic solution for this issue would be to be able to configure yarn options.
I tried to use npmOptions parameter from the ember-try config but seems it is not respected when useYarn is set to true.

@kategengler
Copy link
Member

npmOptions should be used with useYarn as well. Can you run with DEBUG=ember-try* <your ember-try command> to get output that will tell us what command is being run?

@kategengler
Copy link
Member

@andreyfel Is this still happening?

@oliverlangan
Copy link

I can verify that npmOptions are being passed to yarn. Note that '--no-optional' is the npm flag, while '--ignore-optional' is the yarn flag. Using the above DEBUG=... command, this is the yarn command that was run:

yarn install --ignore-optional --no-lockfile --ignore-engines

That said, it still installed optionalDependencies in a sub-package, at least on our CI environment.

(Recent releases of ember-lodash use optionalDependencies if you are looking for a package with which to test.)

@rwjblue
Copy link
Member

rwjblue commented Nov 2, 2020

FWIW #409 made it possible to control exactly what is passed in to each of the dependency managers. I'm going to close now, but if folks still think this is a bug I'm happy to reopen.

@rwjblue rwjblue closed this as completed Nov 2, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants