Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ember/use-ember-data-rfc-395-imports: Typescript and registries #1833

Closed
bartocc opened this issue Apr 11, 2023 · 2 comments
Closed

ember/use-ember-data-rfc-395-imports: Typescript and registries #1833

bartocc opened this issue Apr 11, 2023 · 2 comments
Labels

Comments

@bartocc
Copy link

bartocc commented Apr 11, 2023

When using ember-data with typescript, you have to add your models to the ModelRegistry type, as explained in the ember-cli-typescript docs: https://docs.ember-cli-typescript.com/ts/using-ts-effectively

If you want to import this ModelRegistry type later in another file, you'll have to do this with import type { ModelRegistry } from "ember-data/model";, which will be a violation to the rule ember/use-ember-data-rfc-395-imports.

I believe this rule should be updated to ignore these specific registries imports.

@wagenet
Copy link
Contributor

wagenet commented Dec 11, 2023

@bartocc I have a fix for this in #2027.

@bartocc
Copy link
Author

bartocc commented Dec 11, 2023

@bartocc I have a fix for this in #2027.

Thx @wagenet !

@bmish bmish closed this as not planned Won't fix, can't repro, duplicate, stale Dec 12, 2023
@bmish bmish reopened this Dec 12, 2023
@bmish bmish closed this as completed Dec 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants