Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ensure super() called with args in hooks #1784

Open
bmish opened this issue Feb 15, 2023 · 1 comment · May be fixed by #1836
Open

Ensure super() called with args in hooks #1784

bmish opened this issue Feb 15, 2023 · 1 comment · May be fixed by #1836
Labels
Enhancement New Rule Idea for a new lint rule

Comments

@bmish
Copy link
Member

bmish commented Feb 15, 2023 •
edited

Came up here: ef4/ember-data-relationship-tracker#25 (review)

Could be added to: ember/require-super-in-lifecycle-hooks

Related:
@bmish bmish added Enhancement New Rule Idea for a new lint rule labels Feb 15, 2023
@bmish bmish changed the title Ensure super() called with args Ensure super() called with args in hooks Feb 15, 2023
@samridhivig samridhivig linked a pull request Apr 17, 2023 that will close this issue
Open
@samridhivig
Copy link

PR for the same: #1836

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Enhancement New Rule Idea for a new lint rule
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add requireArgs option in require-super-in-lifecycle-hooks rule samridhivig/eslint-plugin-ember
2 participants
@bmish @samridhivig