Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

no-unused-expressions #2035

Open
amk221 opened this issue Dec 20, 2023 · 4 comments
Open

no-unused-expressions #2035

amk221 opened this issue Dec 20, 2023 · 4 comments

Comments

@amk221
Copy link
Contributor

amk221 commented Dec 20, 2023

Class based gjs files get linted fine. But template only gjs files fail like this:

Reproduction:

amk221/-ember-template-imports-eslint-unused-expression@ff4504e

Versions:

├── @babel/core@7.23.6
├── @babel/eslint-parser@7.23.3
├── @babel/plugin-proposal-decorators@7.23.6
├── ember-cli-babel@8.2.0
├── ember-source@5.5.0
├── ember-template-imports@4.0.0
├── ember-template-lint@5.13.0
├── eslint-plugin-ember@11.12.0
├── eslint-plugin-n@16.5.0
├── eslint-plugin-qunit@8.0.1
├── eslint@8.56.0
@bmish
Copy link
Member

bmish commented Dec 20, 2023

@NullVoxPopuli @patricklx

@patricklx
Copy link
Contributor

its using eslint-plugin-ember@11.12.0
I do not see this issue in the alpha release.
@amk221 can you try to alpha release and check if you still have the issue?

@amk221
Copy link
Contributor Author

amk221 commented Dec 20, 2023

Thanks, yes that does fix it

It it instead output

 Parsing error: This experimental syntax requires enabling one of the following parser plugin(s): "jsx", "flow", "typescript". (1:0)

I don't know what that is, but happy that its fixed in 12 :)

@patricklx
Copy link
Contributor

patricklx commented Dec 20, 2023

Looks like eslint ember plugin fails to notify to setup the correct config in this case:
https://github.com/ember-cli/eslint-plugin-ember?tab=readme-ov-file#gtsgjs

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants