Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Avoid crash from classes extending a non-identifier superclass during Ember core module check #906

Merged
merged 1 commit into from Aug 7, 2020
Merged

Avoid crash from classes extending a non-identifier superclass during Ember core module check #906

merged 1 commit into from Aug 7, 2020

Conversation

bmish
Copy link
Member

@bmish bmish commented Aug 6, 2020

Fixes #905. CC: @buschtoens

Ensures that this example does not cause an assert:

class TestObject extends this.ContainerObject {
  // ...
}

@rwjblue
Copy link
Member

rwjblue commented Aug 7, 2020

Thanks for working on this!

@bmish bmish changed the title Ignore classes extending a non-identifier super class in Ember core module check Avoid crash from classes extending a non-identifier superclass during Ember core module check Aug 7, 2020
@bmish bmish merged commit b673ed6 into ember-cli:master Aug 7, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

no-new-mixins: getSourceModuleName should only be called on a CallExpression, MemberExpression or Identifier
2 participants