Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Check imports in require-computed-property-dependencies rule #907

Merged
merged 1 commit into from Aug 7, 2020
Merged

Check imports in require-computed-property-dependencies rule #907

merged 1 commit into from Aug 7, 2020

Conversation

bmish
Copy link
Member

@bmish bmish commented Aug 7, 2020

Checks what name Ember and computed are imported under when detecting computed properties, instead of just assuming that they are imported under the standard names.

CC: @mongoose700

Helps with #590.

@bmish bmish added the Bug label Aug 7, 2020
@bmish bmish merged commit 7467c37 into ember-cli:master Aug 7, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant