Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Check imported get/getProperties/getWithDefault functions for missing dependencies in require-computed-property-dependencies rule #908

Merged
merged 1 commit into from Aug 7, 2020
Merged

Check imported get/getProperties/getWithDefault functions for missing dependencies in require-computed-property-dependencies rule #908

merged 1 commit into from Aug 7, 2020

Conversation

bmish
Copy link
Member

@bmish bmish commented Aug 7, 2020

Previously, we only checked this.get(...) and Ember.get(...), but not the imported version import { get } from '@ember/object'; get(...) of these functions, when searching for missing dependent keys in computed properties.

CC: @mongoose700

…ssing dependencies in require-computed-property-dependencies rule
@bmish bmish added the Bug label Aug 7, 2020
@bmish bmish merged commit d7fadfe into ember-cli:master Aug 7, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants