New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

jquery-api's codemod incorrectly transforms custom events #39

Open

runspired opened this issue Dec 1, 2021 · 0 comments

Labels

bug

runspired commented Dec 1, 2021

since these are custom jquery events they would not be subscribable in this way:

-            this.$(".modal.show")
-              .on("hidden.bs.modal", (e) => {
+            this.element.querySelectorAll(".modal.show").forEach(el => el.addEventListener("hidden.bs.modal", (e) => {
                 if (this.allAssigned) {
                   this.sendAction("allAssigned");
                 }
                 $(e.currentTarget).unbind();
-              })
+              }))

The text was updated successfully, but these errors were encountered:

rajasegar added the bug label

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment