Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

jquery-api's codemod incorrectly transforms click handlers #40

Open
runspired opened this issue Dec 1, 2021 · 0 comments
Open

jquery-api's codemod incorrectly transforms click handlers #40

runspired opened this issue Dec 1, 2021 · 0 comments
Labels
bug Something isn't working

Comments

@runspired
Copy link

example where the event name ("click") was not passed to addEventListener:

-    this.$(".nav-link").click(function () {
+    this.element.querySelectorAll(".nav-link").forEach(el => el.addEventListener(function () {
       if ($(this).hasClass("active")) {
         analyticsRunner.set("hideAnalyticsRunner", false);
       }
-    });
+    }));
@rajasegar rajasegar added the bug Something isn't working label Dec 2, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants