Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

suppressBrowserRender should either be renamed or updated #42

Open
reidab opened this issue Nov 6, 2017 · 4 comments
Open

suppressBrowserRender should either be renamed or updated #42

reidab opened this issue Nov 6, 2017 · 4 comments

Comments

@reidab
Copy link

reidab commented Nov 6, 2017

As of 0.4.0, the suppressBrowserRender option doesn't really do what it says on the tin. Since the instance-initializer no longer injects {{head-layout}}, returning early from it doesn't actually suppress any rendering.

@rwjblue
Copy link
Member

rwjblue commented Nov 6, 2017

cc @rondale-sc

@rondale-sc
Copy link
Contributor

rondale-sc commented Nov 20, 2017

@reidab I think maybe that shouldn't be config anymore. Since the consuming application is responsible now for when head-layout component gets rendered I'd expect to have that logic co-located with the component call.

Something like:

{{#if fastboot.isFastBoot }}
  {{ head-layout }}
{{/if}}

If that is the case we need to update the README to remove suppressBrowserRender as an option. And remove any logic around it.

@rwjblue thoughts?

@nolman
Copy link

nolman commented Apr 30, 2018

Just a heads up - we are using this to dynamically select which CSS gets loaded for our app, when we disable the suppressBrowserRender in fastboot when the app rehydrates the css vanishes as everything in {{head-layout}} gets removed. Not sure what the right name for this variable is but it most likely needs to stay around to prevent triggering a CSS reload.

@Duder-onomy
Copy link

I have been running into this issue as well.
Fastboot+Ember renders the head, along with all of its special bits (meta tags, structured data etc)
Ember comes down the pipe and crushes all of those bits.

If I do what @rondale-sc suggests (wrap the {{head-layout}} in a {{fastboot.isFastBoot}} check. It fixes my problem.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants