Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Workers can't recover from no distPath. #97

Open
nathanhammond opened this issue Feb 25, 2019 · 0 comments
Open

Workers can't recover from no distPath. #97

nathanhammond opened this issue Feb 25, 2019 · 0 comments

Comments

@nathanhammond
Copy link
Contributor

nathanhammond commented Feb 25, 2019

Workers are started just once:

this.middleware is only set here:

if (!this.distPath) {
this.middleware = this.noAppMiddleware();
} else {
this.middleware = this.buildMiddleware();
}

And then you're stuck with that middleware forever:

return this.httpServer.serve(this.middleware)

For bonus points, fastbootMiddleware here:

serve(fastbootMiddleware) {

...is therefore possibly not a FastBoot middleware which is a super troll since we expose httpServer as a downstream API.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant