Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Doesn't work with disabled addons #362

Open
ryanto opened this issue Apr 27, 2019 · 0 comments
Open

Doesn't work with disabled addons #362

ryanto opened this issue Apr 27, 2019 · 0 comments

Comments

@ryanto
Copy link
Contributor

ryanto commented Apr 27, 2019

I've got an addon that's made for testing & development, so I'm using ember-cli's isEnabled hook to disable the addon in production environments.

isEnabled() {
  return this.app.env !== "production";
}

I just noticed that this returns false when ember deploy production is run. The deploy completes, but what is shipped to gh-pages is not a complete addon docs app. The docs subfolder is missing and the app errors when it tries to request the json file with all modules.

For now I've set isEnabled to always return true, but I'm wondering if I can somehow have this hook detect if it's running as part of an addon docs deploy?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant