Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Styles don't play nice with disabled application-template-wrapper #422

Open
josemarluedke opened this issue Nov 1, 2019 · 6 comments
Open

Comments

@josemarluedke
Copy link
Contributor

When using addon-docs on an app with application-template-wrapper set to false (which is default in octane), the app styles don't work well. See below:

body > .ember-view {
@apply .docs-flex-1;
@apply .docs-flex;
@apply .docs-flex-col;
@apply .docs-mt-1;
@apply .docs-bg-white;
}

Screen Shot 2019-11-01 at 3 02 55 PM

This is simple to fix, but it would be better to not break for these cases.
The fix is just wrapping the content of application.hbs with a div with classes ember-view:

<div class="ember-view">
  <DocsHeader />

  {{outlet}}
</div>
@RobbieTheWagner
Copy link
Member

@josemarluedke if we wrap it, does it mess up styles if it is double wrapped?

@josemarluedke
Copy link
Contributor Author

It does mess up a few things if double wrapped.

@RobbieTheWagner
Copy link
Member

Perhaps we should just put a note that you should wrap it?

@NullVoxPopuli
Copy link

I just ran in to this. I had to:
set: application-template-wrapper to true.
remove "editions": "octane" from package.json :-\

@RobbieTheWagner
Copy link
Member

@NullVoxPopuli any interest in taking a look at a fix? Can you not manually wrap in <div class="ember-view">?

@NullVoxPopuli
Copy link

omg yes. Yesterday me was an idiot. thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants