Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow working out of the box on CI jobs with Github Actions #437

Open
alexdiliberto opened this issue Dec 15, 2019 · 0 comments
Open

Allow working out of the box on CI jobs with Github Actions #437

alexdiliberto opened this issue Dec 15, 2019 · 0 comments

Comments

@alexdiliberto
Copy link

alexdiliberto commented Dec 15, 2019

Currently, if you run on Travis and leave addon-docs.js empty it will just work because it falls back to process.env.TRAVIS_BRANCH to grab the correct getVersionPath

We should allow the same fallback behavior for Github Actions.

If, when using Github Actions, you don't explicitly set you getVersionPath() or ADDON_DOCS_VERSION_PATH you would get error:

Run yarn ember deploy production
yarn run v1.19.2
$ /home/runner/work/ember-transformicons/ember-transformicons/node_modules/.bin/ember deploy production
no addon-docs version path configured; skipping deploy
undefinedPipeline aborted
error Command failed with exit code 1.
info Visit https://yarnpkg.com/en/docs/cli/run for documentation about this command.
##[error]Process completed with exit code 1.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant