Rule request: [embroider-ready]

[lifeart]

Embroider could not find all possible dynamic usecases of dynamic helper, modifier and component.

In scope of this rule, we could highlight it (as warning, for example) to users to simplify migration.

Refs:

embroider-build/embroider#1120 (comment)

Cases to warn:

{{component (or @a "b" "c")}}

{{#let (component (or @a "b" "c")) as |A|}}
   <A/>
{{{/let}}

{{helper (or @a "b" "c")}}
{{#let (helper (or @a "b" "c")) as |A|}}
  {{A}}
{{{/let}}
{{modifier (or @a "b" "c")}}
{{#let (modifier (or @a "b" "c")) as |A|}}
   <div {{A}} />
{{{/let}}

Check details:

{
    PathExpression(node, path) {
      if (['modifier', 'helper', 'component'].includes(node.original)) {
        const parent = path.parent.node;
        if (!parent.params.length) {
          return;
        }
        const type = parent.params[0].type;
        const allowedArgumentTypes = ['PathExpression', 'StringLiteral'];

        if (!allowedArgumentTypes.includes(type)) {
          const source = env.syntax.print(parent);
          console.warn(`${source} is not supported with embroider, move this logic inside js class`); 
        }
      }
    }
  };

Example:

https://astexplorer.net/#/gist/2509d2732e9e5b05d31a61b2693691e5/9223800e70e87eca3c560ad232d94faa1f8ae523

[ef4]

Only the component keyword arguably needs a lint.

Non-string-literal usage of helper and modifier keywords was never allowed and throws a hard error.