Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

no-obscure-array-access fix is incorrect with modifier usage #2924

Open
Alonski opened this issue Jun 21, 2023 · 0 comments
Open

no-obscure-array-access fix is incorrect with modifier usage #2924

Alonski opened this issue Jun 21, 2023 · 0 comments
Labels

Comments

@Alonski
Copy link
Contributor

Alonski commented Jun 21, 2023

Failing PR:
#2923

This code:

<Button @onClick={{fn this.myFunc @row.0.sha256}}>
  Button
</Button>

Is expected to be fixed to:

<Button @onClick={{fn this.myFunc (get @row "0.sha256")}}>
  Button
</Button>

But instead is fixed to:

<Button @onClick={{fn @row "0.sha256"}}>
  Button
</Button>

Which is incorrect. The function this.myFunc is now gone.

@bmish bmish added the bug label Jun 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants