New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve builtin-component-arguments rule to lint against "radio" inputs #2963

Open

lifeart opened this issue Aug 14, 2023 · 1 comment

Labels

enhancement good first issue

Collaborator

lifeart commented Aug 14, 2023 •

edited

This code is invalid with ember:

<Input @type="radio" name="my-radio" @checked={{true}} />

Ref: emberjs/ember.js#4352

At the moment, Input type="radio" is not really supported by ember:

https://github.com/emberjs/ember.js/blob/main/packages/%40ember/-internals/glimmer/tests/integration/components/input-curly-test.js
https://github.com/emberjs/ember.js/blob/main/packages/%40ember/-internals/glimmer/tests/integration/components/input-angle-test.js

(there is no tests for it.)

Related conversation: ember-cli/eslint-plugin-ember#1932

Playground with repro: https://stackblitz.com/edit/ember-cli-editor-output-eebuuq?file=app%2Ftemplates%2Fapplication.hbs

lifeart added enhancement good first issue labels

Contributor

NullVoxPopuli commented Aug 14, 2023

may as well lint against <Input> and <Textarea> altogether

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment