Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

New rule: no-jsx-attributes #2977

Open
NullVoxPopuli opened this issue Sep 13, 2023 · 0 comments · May be fixed by #2978
Open

New rule: no-jsx-attributes #2977

NullVoxPopuli opened this issue Sep 13, 2023 · 0 comments · May be fixed by #2978
Labels
enhancement New Rule

Comments

@NullVoxPopuli
Copy link
Contributor

className is not valid in HTML, so we shouldn't allow it.

It comes from React / JSX, and doesn't do what folks are expecting.

It does properly set an attribute on an element called className, because all attributes are valid in HTML, but the intent behind className is to set the class attribute.

This is somewhat similar to this new rule request: #2043
NullVoxPopuli added a commit to NullVoxPopuli/ember-template-lint that referenced this issue Sep 14, 2023
@NullVoxPopuli
Resolves ember-template-lint#2977: Create no-jsx-attributes rule
d01f6bb
@NullVoxPopuli NullVoxPopuli linked a pull request Sep 14, 2023 that will close this issue
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New Rule
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add new rule no-jsx-attributes NullVoxPopuli/ember-template-lint
2 participants
@NullVoxPopuli @bmish