Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ember-template-lint "overrides" config does not work with eslint-plugin-hbs #40

Open
tstewart15 opened this issue Oct 12, 2020 · 2 comments

Comments

@tstewart15
Copy link

Duplicate of #37 since it was closed and I cannot re-open it.

@jaydgruber
Copy link

Yeah, this still seems to be an issue. ember-template-lint/ember-template-lint#1495 fixed an issue with parsing the overrides. Now if I log linter.config.overrides at: https://github.com/ember-template-lint/eslint-plugin-hbs/blob/master/lib/rules/check-hbs-template-literals.js#L65, the overrides are present. But on https://github.com/ember-template-lint/eslint-plugin-hbs/blob/master/lib/rules/check-hbs-template-literals.js#L78, we are not passing the filePath that the template-linter Node API expects. So it has no way to know to apply the overrides. Looking into this to see to see if I can figure out where to grab the filepath from.

@jaydgruber
Copy link

Seems like if I just add filePath: context.getFilename() to the linter.verify() options on #L78, this should work. Will see if I can get a PR up w/ a test.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants