Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

no-this-in-template-only-components: improve app structure detection #1707

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

dwickern
Copy link
Contributor

Improves isTemplateOnlyComponent to support linting some more file structures:

@@ -61,6 +71,8 @@ generateRuleTests({
{
template: '{{input id=(concat this.elementId "-username")}}',
result: {
filePath: 'app/components/foo.hbs',
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

filePath may be absolute fs path

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ya, but I think we can't really fix this until workingDir lands.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Not sure how to handle/fix "no-this-in-template-only-components"
3 participants