Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

broken build #9

Open
burrows opened this issue Oct 24, 2011 · 1 comment
Open

broken build #9

burrows opened this issue Oct 24, 2011 · 1 comment

Comments

@burrows
Copy link

burrows commented Oct 24, 2011

I'm seeing a couple of issues when trying to build the sproutcore-statechart framework.

The first is that the self-executing anonymous functions that get wrapped around each file's contents do not have a trailing semicolon. When you have two of these back to back, its interpreted as chained function calls and triggers an exception.

(function() {})()
(function() {})()
// => TypeError: function () {}() is not a function

This issue can be fixed by removing the following lines of code from the Rakefile:

module SproutCore
  module Compiler
    class Entry
      def body
        "\n(function(exports) {\n#{@raw_body}\n})({})\n"
      end 
    end 
  end 
end

The second and larger issue is that the files are getting built out of order. SC.EmptyState is getting defined before SC.State, which is a problem because SC.EmptyState extends SC.State. The dependencies in lib/system.js are not listed in the correct order, but fixing the order does not seem to affect the build.

@benjixx
Copy link
Contributor

benjixx commented Nov 30, 2011

This issue can be closed as well, as it is solved by #12.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants