Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Revert consume length for autotracking on ManyArray once LTS changes in Ember.js is fixed #7346

Closed
snewcomer opened this issue Oct 7, 2020 · 3 comments
Closed

Revert consume length for autotracking on ManyArray once LTS changes in Ember.js is fixed #7346

snewcomer opened this issue Oct 7, 2020 · 3 comments
Assignees
@snewcomer

Comments

@snewcomer
Copy link
Contributor

snewcomer commented Oct 7, 2020 •
edited

Ref PR in data to get users unblocked in 3.22.0: #7330. We need to revert the length instrumentation when changes in Ember.js are done and implemented in a cominng Ember LTS 3.20.6 release.
@snewcomer snewcomer self-assigned this Oct 7, 2020
@runspired
Copy link
Contributor

Is this now revertable?

@snewcomer
Copy link
Contributor Author

I think so!

@runspired
Copy link
Contributor

no longer necessary, we actually want to consume length due to changes to make it lazy.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@snewcomer snewcomer

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@runspired @snewcomer