Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: emberjs/ember-qunit
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: v6.2.0
Choose a base ref
...
head repository: emberjs/ember-qunit
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: v7.0.0
Choose a head ref

Commits on Feb 25, 2023

  1. Merge pull request #1028 from emberjs/release-v6.2.0

    Release 6.2.0
    chriskrycho authored Feb 25, 2023
    Copy the full SHA
    ad6bb0b View commit details

Commits on Mar 1, 2023

  1. Bump @babel/core from 7.20.12 to 7.21.0

    Bumps [@babel/core](https://github.com/babel/babel/tree/HEAD/packages/babel-core) from 7.20.12 to 7.21.0.
    - [Release notes](https://github.com/babel/babel/releases)
    - [Changelog](https://github.com/babel/babel/blob/main/CHANGELOG.md)
    - [Commits](https://github.com/babel/babel/commits/v7.21.0/packages/babel-core)
    
    ---
    updated-dependencies:
    - dependency-name: "@babel/core"
      dependency-type: direct:development
      update-type: version-update:semver-minor
    ...
    
    Signed-off-by: dependabot[bot] <support@github.com>
    dependabot[bot] authored Mar 1, 2023
    Copy the full SHA
    d007c1e View commit details
  2. Bump eslint from 8.33.0 to 8.35.0

    Bumps [eslint](https://github.com/eslint/eslint) from 8.33.0 to 8.35.0.
    - [Release notes](https://github.com/eslint/eslint/releases)
    - [Changelog](https://github.com/eslint/eslint/blob/main/CHANGELOG.md)
    - [Commits](eslint/eslint@v8.33.0...v8.35.0)
    
    ---
    updated-dependencies:
    - dependency-name: eslint
      dependency-type: direct:development
      update-type: version-update:semver-minor
    ...
    
    Signed-off-by: dependabot[bot] <support@github.com>
    dependabot[bot] authored Mar 1, 2023
    Copy the full SHA
    f53aba2 View commit details
  3. Bump prettier from 2.8.3 to 2.8.4

    Bumps [prettier](https://github.com/prettier/prettier) from 2.8.3 to 2.8.4.
    - [Release notes](https://github.com/prettier/prettier/releases)
    - [Changelog](https://github.com/prettier/prettier/blob/main/CHANGELOG.md)
    - [Commits](prettier/prettier@2.8.3...2.8.4)
    
    ---
    updated-dependencies:
    - dependency-name: prettier
      dependency-type: direct:development
      update-type: version-update:semver-patch
    ...
    
    Signed-off-by: dependabot[bot] <support@github.com>
    dependabot[bot] authored Mar 1, 2023
    Copy the full SHA
    fde8b27 View commit details
  4. Bump ember-auto-import from 2.6.0 to 2.6.1

    Bumps [ember-auto-import](https://github.com/ef4/ember-auto-import/tree/HEAD/packages/ember-auto-import) from 2.6.0 to 2.6.1.
    - [Release notes](https://github.com/ef4/ember-auto-import/releases)
    - [Changelog](https://github.com/ef4/ember-auto-import/blob/main/packages/ember-auto-import/CHANGELOG.md)
    - [Commits](https://github.com/ef4/ember-auto-import/commits/v2.6.1/packages/ember-auto-import)
    
    ---
    updated-dependencies:
    - dependency-name: ember-auto-import
      dependency-type: direct:production
      update-type: version-update:semver-patch
    ...
    
    Signed-off-by: dependabot[bot] <support@github.com>
    dependabot[bot] authored Mar 1, 2023
    Copy the full SHA
    5deddef View commit details
  5. Merge pull request #1031 from emberjs/dependabot/npm_and_yarn/babel/c…

    …ore-7.21.0
    
    Bump @babel/core from 7.20.12 to 7.21.0
    wagenet authored Mar 1, 2023
    Copy the full SHA
    945907a View commit details
  6. Merge pull request #1032 from emberjs/dependabot/npm_and_yarn/eslint-…

    …8.35.0
    
    Bump eslint from 8.33.0 to 8.35.0
    wagenet authored Mar 1, 2023
    Copy the full SHA
    90f0c72 View commit details
  7. Merge pull request #1033 from emberjs/dependabot/npm_and_yarn/prettie…

    …r-2.8.4
    
    Bump prettier from 2.8.3 to 2.8.4
    wagenet authored Mar 1, 2023
    Copy the full SHA
    50ae0a5 View commit details
  8. Bump @xmldom/xmldom from 0.8.3 to 0.8.6

    Bumps [@xmldom/xmldom](https://github.com/xmldom/xmldom) from 0.8.3 to 0.8.6.
    - [Release notes](https://github.com/xmldom/xmldom/releases)
    - [Changelog](https://github.com/xmldom/xmldom/blob/master/CHANGELOG.md)
    - [Commits](xmldom/xmldom@0.8.3...0.8.6)
    
    ---
    updated-dependencies:
    - dependency-name: "@xmldom/xmldom"
      dependency-type: indirect
    ...
    
    Signed-off-by: dependabot[bot] <support@github.com>
    dependabot[bot] authored Mar 1, 2023
    Copy the full SHA
    fef9efd View commit details
  9. Bump minimist from 0.2.2 to 0.2.4

    Bumps [minimist](https://github.com/minimistjs/minimist) from 0.2.2 to 0.2.4.
    - [Release notes](https://github.com/minimistjs/minimist/releases)
    - [Changelog](https://github.com/minimistjs/minimist/blob/main/CHANGELOG.md)
    - [Commits](minimistjs/minimist@v0.2.2...v0.2.4)
    
    ---
    updated-dependencies:
    - dependency-name: minimist
      dependency-type: indirect
    ...
    
    Signed-off-by: dependabot[bot] <support@github.com>
    dependabot[bot] authored Mar 1, 2023
    Copy the full SHA
    1f6848e View commit details
  10. Bump release-it from 15.6.0 to 15.7.0

    Bumps [release-it](https://github.com/release-it/release-it) from 15.6.0 to 15.7.0.
    - [Release notes](https://github.com/release-it/release-it/releases)
    - [Changelog](https://github.com/release-it/release-it/blob/main/CHANGELOG.md)
    - [Commits](release-it/release-it@15.6.0...15.7.0)
    
    ---
    updated-dependencies:
    - dependency-name: release-it
      dependency-type: direct:development
      update-type: version-update:semver-minor
    ...
    
    Signed-off-by: dependabot[bot] <support@github.com>
    dependabot[bot] authored Mar 1, 2023
    Copy the full SHA
    ae103d0 View commit details

Commits on Mar 2, 2023

  1. Copy the full SHA
    cbc93c0 View commit details
  2. Copy the full SHA
    98cd9e7 View commit details
  3. Copy the full SHA
    f0124ca View commit details
  4. Copy the full SHA
    22f928b View commit details

Commits on Jun 2, 2023

  1. Copy the full SHA
    431771a View commit details

Commits on Jun 8, 2023

  1. update node versions

    MelSumner committed Jun 8, 2023
    Copy the full SHA
    e157c99 View commit details
  2. different node version

    MelSumner committed Jun 8, 2023
    Copy the full SHA
    224081a View commit details

Commits on Jun 9, 2023

  1. Copy the full SHA
    40e7e5b View commit details
  2. fix some types/tests

    MelSumner committed Jun 9, 2023
    Copy the full SHA
    dabc20b View commit details
  3. Copy the full SHA
    56cf60e View commit details
  4. removing unused imports

    MelSumner committed Jun 9, 2023
    Copy the full SHA
    cdfc7f0 View commit details
  5. Copy the full SHA
    d173455 View commit details
  6. Copy the full SHA
    2119524 View commit details
  7. Copy the full SHA
    a178bb7 View commit details
  8. Copy the full SHA
    a0aeb62 View commit details
  9. Copy the full SHA
    5fe649c View commit details
  10. Copy the full SHA
    12f7731 View commit details

Commits on Jun 10, 2023

  1. Copy the full SHA
    07aa3ca View commit details

Commits on Jun 12, 2023

  1. Release 7.0.0

    MelSumner committed Jun 12, 2023
    Copy the full SHA
    2bfd333 View commit details
Showing with 278 additions and 326 deletions.
  1. +0 −1 .github/workflows/ci.yml
  2. +15 −0 CHANGELOG.md
  3. +1 −1 addon-test-support/adapter.js
  4. +13 −12 package.json
  5. +19 −22 types/tests.ts
  6. +230 −290 yarn.lock
1 change: 0 additions & 1 deletion .github/workflows/ci.yml
Original file line number Diff line number Diff line change
@@ -48,7 +48,6 @@ jobs:
fail-fast: true
matrix:
ember-try-scenario:
- ember-lts-3.28
- ember-lts-4.4
- ember-lts-4.8
- ember-release
15 changes: 15 additions & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
@@ -1,5 +1,20 @@



## v7.0.0 (2023-06-12)

#### :boom: Breaking Change
* [#1077](https://github.com/emberjs/ember-qunit/pull/1077) Upgrade ember-test-helpers and node ([@MelSumner](https://github.com/MelSumner))

#### :house: Internal
* [#1077](https://github.com/emberjs/ember-qunit/pull/1077) Upgrade ember-test-helpers and node ([@MelSumner](https://github.com/MelSumner))
* [#1028](https://github.com/emberjs/ember-qunit/pull/1028) Release 6.2.0 ([@chriskrycho](https://github.com/chriskrycho))

#### Committers: 2
- Chris Krycho ([@chriskrycho](https://github.com/chriskrycho))
- Melanie Sumner ([@MelSumner](https://github.com/MelSumner))


## v6.2.0 (2023-02-25)

#### :rocket: Enhancement
2 changes: 1 addition & 1 deletion addon-test-support/adapter.js
Original file line number Diff line number Diff line change
@@ -12,7 +12,7 @@ function unhandledRejectionAssertion(current, error) {
message = error;
source = 'unknown source';
} else {
message = 'unhandledRejection occured, but it had no message';
message = 'unhandledRejection occurred, but it had no message';
source = 'unknown source';
}

25 changes: 13 additions & 12 deletions package.json
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
{
"name": "ember-qunit",
"version": "6.2.0",
"version": "7.0.0",
"description": "QUnit helpers for testing Ember.js applications",
"keywords": [
"ember-addon"
@@ -38,18 +38,19 @@
"broccoli-funnel": "^3.0.8",
"broccoli-merge-trees": "^3.0.2",
"common-tags": "^1.8.0",
"ember-auto-import": "^2.6.0",
"ember-auto-import": "^2.6.1",
"ember-cli-babel": "^7.26.11",
"ember-cli-test-loader": "^3.0.0",
"resolve-package-path": "^4.0.3",
"silent-error": "^1.1.1",
"validate-peer-dependencies": "^2.2.0"
},
"devDependencies": {
"@babel/core": "^7.20.5",
"@babel/core": "^7.21.0",
"@babel/eslint-parser": "^7.19.1",
"@ember/optional-features": "^2.0.0",
"@ember/test-helpers": "^2.9.3",
"@ember/string": "^3.1.1",
"@ember/test-helpers": "^3.0.3",
"@embroider/test-setup": "^2.1.1",
"@glimmer/component": "^1.1.2",
"@tsconfig/ember": "^2.0.0",
@@ -67,28 +68,28 @@
"ember-source": "~4.10.0",
"ember-source-channel-url": "^3.0.0",
"ember-try": "^2.0.0",
"eslint": "^8.33.0",
"eslint": "^8.35.0",
"eslint-config-prettier": "^8.6.0",
"eslint-plugin-disable-features": "^0.1.3",
"eslint-plugin-node": "^11.1.0",
"eslint-plugin-prettier": "^4.2.1",
"expect-type": "^0.15.0",
"loader.js": "^4.7.0",
"npm-run-all": "^4.1.5",
"prettier": "2.8.3",
"prettier": "2.8.4",
"qunit": "^2.19.4",
"release-it": "^15.6.0",
"release-it": "^15.7.0",
"release-it-lerna-changelog": "^5.0.0",
"typescript": "^4.9.5",
"webpack": "^5.75.0"
},
"peerDependencies": {
"@ember/test-helpers": "^2.9.3",
"ember-source": ">=3.28",
"@ember/test-helpers": ">=3.0.3",
"ember-source": ">=4.0.0",
"qunit": "^2.13.0"
},
"engines": {
"node": "14.* || 16.* || >= 18"
"node": "16.* || >= 18"
},
"publishConfig": {
"registry": "https://registry.npmjs.org"
@@ -125,7 +126,7 @@
}
},
"volta": {
"node": "14.19.1",
"yarn": "1.22.18"
"node": "18.16.0",
"yarn": "1.22.19"
}
}
41 changes: 19 additions & 22 deletions types/tests.ts
Original file line number Diff line number Diff line change
@@ -11,10 +11,9 @@ import {
setResolver,
setupRenderingTest,
setupTest,
SetupTestOptions,
setupApplicationTest,
} from 'ember-qunit';
import { render, RenderingTestContext, TestContext } from '@ember/test-helpers';
import { render, TestContext } from '@ember/test-helpers';
import EmberResolver from 'ember-resolver';
import EmberObject from '@ember/object';

@@ -25,30 +24,28 @@ setResolver(EmberResolver.create());
module('rendering', function (hooks) {
setupRenderingTest(hooks);

test('it renders', function (this: RenderingTestContext, assert) {
test('it renders', async function (assert) {
assert.expect(2);

// setup the outer context
this.set('value', 'cat');

// render the component
this.render(hbs`
await render(hbs`
{{ x-foo value=value action="result" }}
`);

// has to be a template
// @ts-expect-error
this.render();
// @ts-expect-error
this.render('{{ x-foo value=value action="result" }}');
await render(hbs);

await render(hbs`{{ x-foo value=value action="result" data-test-content}}`);

const el = this.element.querySelector('div');
assert.equal(el?.innerText, 'cat', 'The component shows the correct value');
assert.equal('[data-test-content]', 'cat', 'The component shows the correct value');

this.element.querySelector('button')?.click();
});

test('it renders', async function (this: RenderingTestContext, assert) {
// this test doesn't make sense, but it also doesn't fail, so I'm setting it to skip until we can improve it.
skip('it renders', async function (assert) {
assert.expect(1);

// creates the component instance
@@ -70,8 +67,8 @@ module('rendering', function (hooks) {
const inputFormat2 = this.get('inputFormat');

// render the component on the page
this.render(hbs`<div>bar</div>`);
assert.equal(this.element.querySelector('div')?.innerText, 'bar');
await render(hbs`<div data-test-content>bar</div>`);
assert.equal('[data-test-content]', 'bar');
});
});

@@ -97,10 +94,10 @@ module('misc and async', function (hooks) {
// This test is intended to ensure the appropriate behavior for @typescript-eslint/no-misused-promises.
// However, we don't actually use typescript-eslint in this project and tslint has no equivalent,
// so we can't properly test it.
test('it can be async', async function (this: RenderingTestContext, assert) {
test('it can be async', async function (assert) {
assert.expect(1);

await this.render(hbs`<p>Hello</p>`);
await render(hbs`<p>Hello</p>`);

assert.ok(true, 'rendered');
});
@@ -112,10 +109,10 @@ module('misc and async', function (hooks) {
// This test is intended to ensure the appropriate behavior for @typescript-eslint/no-misused-promises.
// However, we don't actually use typescript-eslint in this project and tslint has no equivalent,
// so we can't properly test it.
skip('it can skip async', async function (this: RenderingTestContext, assert) {
skip('it can skip async', async function (assert) {
assert.expect(1);

await this.render(hbs`<p>Hello</p>`);
await render(hbs`<p>Hello</p>`);

assert.ok(true, 'rendered');
});
@@ -125,10 +122,10 @@ module('misc and async', function (hooks) {
// so we can't properly test it.
only(
'it can only run async',
async function (this: RenderingTestContext, assert) {
async function (assert) {
assert.expect(1);

await this.render(hbs`<p>Hello</p>`);
await render(hbs`<p>Hello</p>`);

assert.ok(true, 'rendered');
}
@@ -139,10 +136,10 @@ module('misc and async', function (hooks) {
// so we can't properly test it.
todo(
'it can have an async todo',
async function (this: RenderingTestContext, assert) {
async function (assert) {
assert.expect(1);

await this.render(hbs`<p>Hello</p>`);
await render(hbs`<p>Hello</p>`);

assert.ok(true, 'rendered');
}
Loading