Skip to content

Commit a8fac83

Browse files
committedDec 15, 2022
Let ESLint have its way about docstring location
We should tweak this, but not as part of this backporting.
1 parent f476a20 commit a8fac83

File tree

2 files changed

+20
-20
lines changed

2 files changed

+20
-20
lines changed
 

‎addon-test-support/@ember/test-helpers/dom/find-all.ts

+10-10
Original file line numberDiff line numberDiff line change
@@ -5,6 +5,16 @@ import { toArray } from '../ie-11-polyfills';
55
// would simply be defined as a tweaked re-export as `querySelector` is, but it
66
// is non-trivial (to say the least!) to preserve overloads like this while also
77
// changing the return type (from `NodeListOf` to `Array`).
8+
export default function findAll<
9+
K extends keyof (HTMLElementTagNameMap | SVGElementTagNameMap)
10+
>(selector: K): Array<HTMLElementTagNameMap[K] | SVGElementTagNameMap[K]>;
11+
export default function findAll<K extends keyof HTMLElementTagNameMap>(
12+
selector: K
13+
): Array<HTMLElementTagNameMap[K]>;
14+
export default function findAll<K extends keyof SVGElementTagNameMap>(
15+
selector: K
16+
): Array<SVGElementTagNameMap[K]>;
17+
export default function findAll(selector: string): Element[];
818
/**
919
Find all elements matched by the given selector. Similar to calling
1020
`querySelectorAll()` on the test root element, but returns an array instead
@@ -20,16 +30,6 @@ import { toArray } from '../ie-11-polyfills';
2030
</caption>
2131
find('#foo');
2232
*/
23-
export default function findAll<
24-
K extends keyof (HTMLElementTagNameMap | SVGElementTagNameMap)
25-
>(selector: K): Array<HTMLElementTagNameMap[K] | SVGElementTagNameMap[K]>;
26-
export default function findAll<K extends keyof HTMLElementTagNameMap>(
27-
selector: K
28-
): Array<HTMLElementTagNameMap[K]>;
29-
export default function findAll<K extends keyof SVGElementTagNameMap>(
30-
selector: K
31-
): Array<SVGElementTagNameMap[K]>;
32-
export default function findAll(selector: string): Element[];
3333
export default function findAll(selector: string): Element[] {
3434
if (!selector) {
3535
throw new Error('Must pass a selector to `findAll`.');

‎addon-test-support/@ember/test-helpers/dom/find.ts

+10-10
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,16 @@
11
import getElement from './-get-element';
22

33
// Derived from `querySelector` types.
4+
export default function find<
5+
K extends keyof (HTMLElementTagNameMap | SVGElementTagNameMap)
6+
>(selector: K): HTMLElementTagNameMap[K] | SVGElementTagNameMap[K] | null;
7+
export default function find<K extends keyof HTMLElementTagNameMap>(
8+
selector: K
9+
): HTMLElementTagNameMap[K] | null;
10+
export default function find<K extends keyof SVGElementTagNameMap>(
11+
selector: K
12+
): SVGElementTagNameMap[K] | null;
13+
export default function find(selector: string): Element | null;
414
/**
515
Find the first element matched by the given selector. Equivalent to calling
616
`querySelector()` on the test root element.
@@ -16,16 +26,6 @@ import getElement from './-get-element';
1626
findAll('.my-selector');
1727
1828
*/
19-
export default function find<
20-
K extends keyof (HTMLElementTagNameMap | SVGElementTagNameMap)
21-
>(selector: K): HTMLElementTagNameMap[K] | SVGElementTagNameMap[K] | null;
22-
export default function find<K extends keyof HTMLElementTagNameMap>(
23-
selector: K
24-
): HTMLElementTagNameMap[K] | null;
25-
export default function find<K extends keyof SVGElementTagNameMap>(
26-
selector: K
27-
): SVGElementTagNameMap[K] | null;
28-
export default function find(selector: string): Element | null;
2929
export default function find(selector: string): Element | null {
3030
if (!selector) {
3131
throw new Error('Must pass a selector to `find`.');

0 commit comments

Comments
 (0)
Please sign in to comment.