Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug] vendor.js grows by 52 KB in production minified build in 5.6.0 compared to 5.5.0 #20628

Open
boris-petrov opened this issue Jan 24, 2024 · 3 comments

Comments

@boris-petrov
Copy link
Contributor

boris-petrov commented Jan 24, 2024

🐞 Describe the Bug

I updated Ember from 5.5.0 to 5.6.0 and my build failed because vendor.js in a production (minified) build grew by 52 KB.

🔬 Minimal Reproduction

ember new ember-test --pnpm
cd ember-test
ember serve --environment=production

Copy the dist/assets/vendor-*.js somewhere. Downgrade ember-source to 5.5.0. Run a prod build again. Compare the two vendor-XXX.js files.

😕 Actual Behavior

vendor.js is 52 KB more.

🤔 Expected Behavior

No such huge difference.

🌍 Environment

  • Ember: 5.6.0
  • Node.js/npm: v21.6.1
  • OS: Linus
  • Browser: N/A

A bit of discussion:
https://discord.com/channels/480462759797063690/1199763691101503488

cc @wycats, @NullVoxPopuli

@boris-petrov
Copy link
Contributor Author

Perhaps @ef4 might have an idea?

@NullVoxPopuli
Copy link
Sponsor Contributor

I mean, the biggest thing that changed were some glimmer-vm upgrades, so it's possible that that caused the bloat.

It would be great to see some bundle analysis

@boris-petrov
Copy link
Contributor Author

boris-petrov commented Mar 5, 2024

5.7.0 is 5kb less than 5.6.0. But still lots more than 5.5.0. 😢

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants