Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Debug render tree tests are not running in specified CI build #20662

Open
kategengler opened this issue Mar 18, 2024 · 0 comments
Open

Debug render tree tests are not running in specified CI build #20662

kategengler opened this issue Mar 18, 2024 · 0 comments

Comments

@kategengler
Copy link
Member

We have a job in the workflow specifically to test debug render tree with production build, for example Production (All Tests + Canary Features with Debug Render Tree).

There is a module of tests guarded here. But if you search the output above for debug render tree you'll find they did not run.

run-tests.js converts the environment variable set in the CI job to a query param for the tests here

if (process.env.DEBUG_RENDER_TREE) {
queryString = `${queryString}&debugrendertree`;
}

and then tests/index.html takes the qunit query param and sets it on the EmberENV

EmberENV['_DEBUG_RENDER_TREE'] = true;

but this update is not reflected when the EmberENV var is checked in that module guard.

I have confirmed the similar technique is working for Ember's optional features and for EXTEND_PROTOTYPES.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant