Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DOC release] fix missing docs for in-element #19063

Merged
merged 1 commit into from Jul 30, 2020
Merged

Conversation

jenweber
Copy link
Contributor

The new API docs for in-element did not render in the API docs viewer due to some stray triple backticks.

@jenweber jenweber changed the title [DOC release-3-20-1] fix missing docs [DOC release-3-20-1] fix missing docs for in-element Jul 30, 2020
Copy link
Sponsor Member

@jaredgalanis jaredgalanis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for this 👍

Copy link
Member

@rwjblue rwjblue left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🤦‍♂

@rwjblue
Copy link
Member

rwjblue commented Jul 30, 2020

CI failure is due to missing entry in tests/docs/expected.js


$ qunit tests/docs/coverage-test.js
285TAP version 13
286ok 1 Docs coverage > classitems > No missing classitems
287not ok 2 Docs coverage > classitems > No extraneous classitems
288  ---
289  message: "If you intentionally removed a public API method, please update tests/docs/expected.js. Otherwise, documentation is missing, incorrectly formatted, or in a directory that is not watched by yuidoc. All files containing documentation must have a yuidoc class declaration."
290  severity: failed
291  actual: [
292  "in-element"
293]
294  expected: []
295  stack:     at Object.<anonymous> (/home/travis/build/emberjs/ember.js/tests/docs/coverage-test.js:33:14)
296  ...
2971..2
298# pass 1
299# skip 0
300# todo 0

@rwjblue
Copy link
Member

rwjblue commented Jul 30, 2020

I can do a patch release in the morning...

@rwjblue rwjblue merged commit 0b6b075 into master Jul 30, 2020
@rwjblue rwjblue deleted the jenweber-patch-1 branch July 30, 2020 13:42
@rwjblue rwjblue changed the title [DOC release-3-20-1] fix missing docs for in-element [DOC release] fix missing docs for in-element Jul 30, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants