Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue with README #7

Open
gavinggordon opened this issue Oct 13, 2016 · 0 comments
Open

Issue with README #7

gavinggordon opened this issue Oct 13, 2016 · 0 comments

Comments

@gavinggordon
Copy link

Main Issue

Hey, there.

Just wanted to let you know about an mistake I found in your README.markdown.

Near the bottom of your README.markdown file, there is an code snippet that looks like this:

   <img src="User avatar" src="{{ gravatar.get(email)|raw }}" />

The error is not with the markdown, specifically, of the snippet, however; the error is in the HTML part of that snippet.

I assume that you know where the error is, and that it was merely an accident. Either way, I have provided you with the corrected snippet below:

   <img alt="User avatar" src="{{ gravatar.get(email)|raw }}" />

The error was that there were 2 'src' attributes and no 'alt' attribute.

More Help

Now, if you wanted to include a snippet which is fully W3C compatible, you could/should also add two more methods to your PHP Class and/or its Twit implementation, which would allow the user to get the 'height' and 'width' values of the image.

By implementating such methods, it would allow the user to be able to do something like this:

   <img alt="User avatar" src="{{ gravatar.get(email)|raw }}" width="{{ gravatar.get(width) }}" height="{{ gravatar.get(height) }}" />

Hopefully that helps!

Sincerely,
Gavin G.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants
@gavinggordon and others