Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sometimes _a_ command needs to run before publish (due to a pnpm bug? idk) #85

Open
NullVoxPopuli opened this issue Feb 20, 2024 · 0 comments

Comments

@NullVoxPopuli
Copy link
Contributor

NullVoxPopuli commented Feb 20, 2024

scenario:

# .npmrc in the repo
ignore-scripts=true

then,

pnpm publish

and then prepack doesn't run 馃槱
which I believe is a bug, as ignore-scripts is not supposed to mean all scripts, and should actually be fixed in pnpm.
See also:

(this is about prepublishOnly, but it's "a" lifecycle hook -- ignore-scripts was only meant for install-based lifecycles, afaict)

idk if it makes sense to add a --build-command="pnpm build" to create-release-plan-setup?

like, this is what I've added for now: https://github.com/NullVoxPopuli/ember-data-resources/pull/408/files#diff-551d1fcf87f78cc3bc18a7b332a4dc5d8773a512062df881c5aba28a6f5c48d7R57

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant