From 73d2748c00c7a3b099ec8f48e5aa22d556bff311 Mon Sep 17 00:00:00 2001 From: Edward Faulkner Date: Tue, 24 May 2022 00:00:31 -0400 Subject: [PATCH] fix default css chunk naming In https://github.com/embroider-build/embroider/pull/1194 we adjusted the webpack outputPath and made a compensating adjustment to the default JS chunk names so they would still end up in the same place. But we neglected to make a compensating change to the default chunk naming for production CSS chunks. This caused the chunks to unintentionally move up one level in the directory hierarchy. This doesn't break anything, but it's inconsistent. This PR puts them back inside "assets" like before. --- packages/webpack/src/ember-webpack.ts | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/packages/webpack/src/ember-webpack.ts b/packages/webpack/src/ember-webpack.ts index 1c4c33036..1f0f6bf62 100644 --- a/packages/webpack/src/ember-webpack.ts +++ b/packages/webpack/src/ember-webpack.ts @@ -568,8 +568,8 @@ const Webpack: PackagerConstructor = class Webpack implements Packager loaders: [MiniCssExtractPlugin.loader, cssLoader], plugins: [ new MiniCssExtractPlugin({ - filename: `chunk.[chunkhash].css`, - chunkFilename: `chunk.[chunkhash].css`, + filename: `assets/chunk.[chunkhash].css`, + chunkFilename: `assets/chunk.[chunkhash].css`, // in the browser, MiniCssExtractPlugin can manage it's own runtime // lazy loading of stylesheets. //