extend existing EmberENV for ember-inspector

[patricklx]

fixes #1251

[patricklx]

if object.assign is not well enough supported for you then this could be used

function(e, t) {
    for (var r in t)
        e[r] = t[r]
    return e
}(window.EmberENV || {}, {...});

[ef4]

Thanks for working on this, this looks like a good fix.

But yes, we do still support Ember 3.x versions and those support IE11, so let's not add Object.assign here.

You can use object spread (because if the app needs IE11 support their babel settings will transpile this):

window.EmberENV={ ...(window.EmberENV || {)}, ...${JSON.stringify(emberENV, null, 2)} }

[void-mAlex]

Thanks for working on this, this looks like a good fix.

But yes, we do still support Ember 3.x versions and those support IE11, so let's not add Object.assign here.

You can use object spread (because if the app needs IE11 support their babel settings will transpile this):

window.EmberENV={ ...(window.EmberENV || {)}, ...${JSON.stringify(emberENV, null, 2)} }

@ef4 I have that exact ie11 use case and I can confirm it doesn't get transpiled.
looks to be the single instance in all the chunks/vendor that is not fixed.

not sure if it is a side effect due to staticEmberSource or not

[ef4]

That's pretty weird, can you check if this exact same code would transpile correctly if you put it into any other spot in your app code?

[ef4]

Oh, I see, I think this is code that gets directly appended to vendor.js. Yeah, that would skip babel. We should strategize what's the cleanest fix.