broccoliBuilderErrorStack … Can't resolve '../../test-waiters' #778

muziejus · 2021-04-26T20:12:47Z

I can't tell if this is related to this issue, but I thought I'd give embroider a try and I get a build failure on step 1 ("First make it work with no options. This is the mode that supports maximum backward compatibility."):

- broccoliBuilderErrorStack: ModuleNotFoundError: Module not found: Error: Can't resolve '../../test-waiters' in '$TMPDIR/embroider/6d8b07/node_modules/@ember/test-helpers/-internal/debug-info.js'

This is with Ember 3.23.1 and Embroider 0.40.0

The text was updated successfully, but these errors were encountered:

angelayanpan · 2022-01-05T21:18:39Z

is anyone looking into this?

ef4 · 2022-01-05T21:31:15Z

@rwjblue mentioned an issue recently with the way that @ember/test-waiters tries to deduplicate itself not playing well with Embroider.

If you use something like yarn resolutions to force your app to have a single copy of @ember/test-waiters, does that workaround the problem?

angelayanpan · 2022-01-05T21:38:33Z

my addon doesn't have ember/test-waiters in package.json

from yarn.lock, I see there are ^3.0.0 and ^2.4.3

which version should my addon try to resolve to?

angelayanpan · 2022-01-05T21:39:44Z

yarn why @ember/test-waiters
yarn why v1.22.4
[1/4] 🤔  Why do we have the module "@ember/test-waiters"...?
[2/4] 🚚  Initialising dependency graph...
[3/4] 🔍  Finding dependency...
[4/4] 🚡  Calculating file sizes...
=> Found "@ember/test-waiters@2.4.5"
info Reasons this module exists
   - "@linkedin#ember-cli-pemberly-tracking" depends on it
   - Hoisted from "@linkedin#ember-cli-pemberly-tracking#@ember#test-waiters"
info Disk size without dependencies: "232KB"
info Disk size with unique dependencies: "3.19MB"
info Disk size with transitive dependencies: "50.08MB"
info Number of shared dependencies: 175
=> Found "@ember/test-helpers#@ember/test-waiters@3.0.0"
info This module exists because "@ember#test-helpers" depends on it.
info Disk size without dependencies: "156KB"
info Disk size with unique dependencies: "1.18MB"
info Disk size with transitive dependencies: "46.15MB"
info Number of shared dependencies: 157

nightire · 2022-01-06T07:40:51Z

@angelayanpan I can confirm to add a resolution entry in the root package.json will fix this issue:

"resolutions": {
  "@ember/test-waiters": "3.0.1"
}

angelayanpan · 2022-01-06T15:55:31Z

thanks! but this is not a permanent solution right?

ef4 · 2022-01-07T01:55:55Z

I think this is fixed by #1064

angelayanpan · 2022-01-11T17:16:21Z

when do you plan to release the above PR?

bertdeblock · 2022-01-11T17:20:54Z

It's already released I think: https://github.com/embroider-build/embroider/blob/master/CHANGELOG.md#v0500-2022-01-08

angelayanpan · 2022-01-11T17:22:31Z

ok, so I have pulled in
"@embroider/compat": "^0.50.0",
"@embroider/core": "^0.50.0",
"@embroider/test-setup": "^0.50.0",
"@embroider/webpack": "^0.50.0",

I still see "can't resolve test-waiters" in my project. I added the resolution back. and don't see that specific error anymore.

ef4 · 2022-01-11T18:01:16Z

Yes, the PR I mentioned above is released on 0.50. This issue may be a combination of people reporting two different problems that interact, and only one of them is fixed.

@angelayanpan is your stack trace still exactly the same as the ones above?

Is the place that's failing to find test-waiters using it via the old import path (ember-test-waiters) or the modern one (@ember/test-waiters)?

angelayanpan · 2022-01-11T18:08:47Z

no occurances of "ember-test-waiters" in our project when I did a search.
my errors look like this:

ERROR in ../../node_modules/@ember/test-helpers/-internal/debug-info.js 17:0-60
Module not found: Error: Can't resolve '@ember/test-waiters' in '$TMPDIR/embroider/dedea7/node_modules/@ember/test-helpers/-internal'
 @ ./assets/test.js 52:9-82

ERROR in ../../node_modules/@ember/test-helpers/settled.js 4:0-56
Module not found: Error: Can't resolve '@ember/test-waiters' in '$TMPDIR/embroider/dedea7/node_modules/@ember/test-helpers'
 @ ./assets/test.js 181:9-69
 
 ERROR in ../../node_modules/@linkedin/ember-cli-pemberly-tracking/modifiers/render-performance.js 62:0-50
Module not found: Error: Can't resolve '@ember/test-waiters' in '$TMPDIR/embroider/dedea7/node_modules/@linkedin/ember-cli-pemberly-tracking/modifiers'
 @ ./assets/dummy.js 4219:9-108

ERROR in ../../node_modules/ember-a11y-testing/test-support/audit.js 5:0-53
Module not found: Error: Can't resolve '@ember/test-waiters' in '$TMPDIR/embroider/dedea7/node_modules/ember-a11y-testing/test-support'
 @ ./assets/test.js 232:9-79

ERROR in ./assets/dummy.js 4123:9-125
Module not found: Error: Can't resolve '../../../node_modules/@linkedin/ember-cli-pemberly-tracking/node_modules/@ember/test-waiters/build-waiter' in '$TMPDIR/embroider/dedea7/tests/dummy/assets'

and more.... (21 errors in total)

rwjblue · 2022-01-11T19:53:35Z

@angelayanpan - This is after updating to @embroider/* 0.50.0?

angelayanpan · 2022-01-11T19:59:48Z

yes @rwjblue

roomman · 2022-01-18T16:26:31Z

Similar situation here. Added @ember/test-waiters to a project with @embroider/* 0.50.2 and getting the following:

ERROR Summary:

  - broccoliBuilderErrorStack: ModuleNotFoundError: Module not found: Error: Can't resolve '@ember/test-waiters' in '/private/var/folders/cp/mp10cjhd1xdf8wg5gk7s9g500000gn/T/embroider/b26e50/authenticators'
    at /Users/simon/Sites/oneday-academy-ui/node_modules/webpack/lib/Compilation.js:2011:28
    at /Users/simon/Sites/oneday-academy-ui/node_modules/webpack/lib/NormalModuleFactory.js:795:13
    at eval (eval at create (/Users/simon/Sites/oneday-academy-ui/node_modules/webpack/node_modules/tapable/lib/HookCodeFactory.js:33:10), <anonymous>:10:1)
    at /Users/simon/Sites/oneday-academy-ui/node_modules/webpack/lib/NormalModuleFactory.js:275:22
    at eval (eval at create (/Users/simon/Sites/oneday-academy-ui/node_modules/webpack/node_modules/tapable/lib/HookCodeFactory.js:33:10), <anonymous>:9:1)
    at /Users/simon/Sites/oneday-academy-ui/node_modules/webpack/lib/NormalModuleFactory.js:431:22
    at /Users/simon/Sites/oneday-academy-ui/node_modules/webpack/lib/NormalModuleFactory.js:124:11
    at /Users/simon/Sites/oneday-academy-ui/node_modules/webpack/lib/NormalModuleFactory.js:667:25
    at /Users/simon/Sites/oneday-academy-ui/node_modules/webpack/lib/NormalModuleFactory.js:852:8
    at /Users/simon/Sites/oneday-academy-ui/node_modules/webpack/lib/NormalModuleFactory.js:972:5
    at /Users/simon/Sites/oneday-academy-ui/node_modules/neo-async/async.js:6883:13
    at /Users/simon/Sites/oneday-academy-ui/node_modules/webpack/lib/NormalModuleFactory.js:955:45
    at finishWithoutResolve (/Users/simon/Sites/oneday-academy-ui/node_modules/webpack/node_modules/enhanced-resolve/lib/Resolver.js:296:11)
    at /Users/simon/Sites/oneday-academy-ui/node_modules/webpack/node_modules/enhanced-resolve/lib/Resolver.js:362:15
    at /Users/simon/Sites/oneday-academy-ui/node_modules/webpack/node_modules/enhanced-resolve/lib/Resolver.js:410:5
    at eval (eval at create (/Users/simon/Sites/oneday-academy-ui/node_modules/webpack/node_modules/tapable/lib/HookCodeFactory.js:33:10), <anonymous>:16:1)
  - code: [undefined]
  - codeFrame: Module not found: Error: Can't resolve '@ember/test-waiters' in '$TMPDIR/embroider/b26e50/authenticators/oneday-firebase.js'
  - errorMessage: authenticators/oneday-firebase.js: Module not found: Error: Can't resolve '@ember/test-waiters' in '$TMPDIR/embroider/b26e50/authenticators/oneday-firebase.js'
        at PackagerRunner (@embroider/webpack)
  - errorType: Build Error
  - location:
    - column: [undefined]
    - file: authenticators/oneday-firebase.js
    - line: [null]
    - treeDir: [undefined]
  - message: authenticators/oneday-firebase.js: Module not found: Error: Can't resolve '@ember/test-waiters' in '$TMPDIR/embroider/b26e50/authenticators/oneday-firebase.js'
        at PackagerRunner (@embroider/webpack)
  - name: Error
  - nodeAnnotation: @embroider/webpack
  - nodeName: PackagerRunner
  - originalErrorMessage: Module not found: Error: Can't resolve '@ember/test-waiters' in '$TMPDIR/embroider/b26e50/authenticators/oneday-firebase.js'
  - stack: ModuleNotFoundError: Module not found: Error: Can't resolve '@ember/test-waiters' in '/private/var/folders/cp/mp10cjhd1xdf8wg5gk7s9g500000gn/T/embroider/b26e50/authenticators'
    at /Users/simon/Sites/oneday-academy-ui/node_modules/webpack/lib/Compilation.js:2011:28
    at /Users/simon/Sites/oneday-academy-ui/node_modules/webpack/lib/NormalModuleFactory.js:795:13
    at eval (eval at create (/Users/simon/Sites/oneday-academy-ui/node_modules/webpack/node_modules/tapable/lib/HookCodeFactory.js:33:10), <anonymous>:10:1)
    at /Users/simon/Sites/oneday-academy-ui/node_modules/webpack/lib/NormalModuleFactory.js:275:22
    at eval (eval at create (/Users/simon/Sites/oneday-academy-ui/node_modules/webpack/node_modules/tapable/lib/HookCodeFactory.js:33:10), <anonymous>:9:1)
    at /Users/simon/Sites/oneday-academy-ui/node_modules/webpack/lib/NormalModuleFactory.js:431:22
    at /Users/simon/Sites/oneday-academy-ui/node_modules/webpack/lib/NormalModuleFactory.js:124:11
    at /Users/simon/Sites/oneday-academy-ui/node_modules/webpack/lib/NormalModuleFactory.js:667:25
    at /Users/simon/Sites/oneday-academy-ui/node_modules/webpack/lib/NormalModuleFactory.js:852:8
    at /Users/simon/Sites/oneday-academy-ui/node_modules/webpack/lib/NormalModuleFactory.js:972:5
    at /Users/simon/Sites/oneday-academy-ui/node_modules/neo-async/async.js:6883:13
    at /Users/simon/Sites/oneday-academy-ui/node_modules/webpack/lib/NormalModuleFactory.js:955:45
    at finishWithoutResolve (/Users/simon/Sites/oneday-academy-ui/node_modules/webpack/node_modules/enhanced-resolve/lib/Resolver.js:296:11)
    at /Users/simon/Sites/oneday-academy-ui/node_modules/webpack/node_modules/enhanced-resolve/lib/Resolver.js:362:15
    at /Users/simon/Sites/oneday-academy-ui/node_modules/webpack/node_modules/enhanced-resolve/lib/Resolver.js:410:5
    at eval (eval at create (/Users/simon/Sites/oneday-academy-ui/node_modules/webpack/node_modules/tapable/lib/HookCodeFactory.js:33:10), <anonymous>:16:1)

=================================================================================

The import statement is import { waitFor } from '@ember/test-waiters'. There are no references to ember-test-waiters in the project.

angelayanpan · 2022-01-18T17:18:42Z

you probably need add to the resolutions mentioned above.

roomman · 2022-01-18T17:39:26Z

Thanks @angelayanpan but this particular project doesn't use Yarn so that's not an option, unless I've missed some recent NPM feature releases?

Edit: so it looks like I did miss something and "overrides" were added to NPM in 8.3.0. Will give that a try now 👍🏻

Edit: added an npm override to my package.json but it did not fix the issue for my project.

vfuto · 2022-07-11T10:28:44Z

@roomman I had the same issue, build failed with adding "@ember/test-waiters": "3.0.1" in resolutions, but after cleaning node_modules (also deleted the build from $TMPDIR/embroider) and running yarn install fixed it.

angelayanpan mentioned this issue Jan 5, 2022

Potential issue with mismatched @ember/test-waiters in dep graph #1056

Open

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

broccoliBuilderErrorStack … Can't resolve '../../test-waiters' #778

broccoliBuilderErrorStack … Can't resolve '../../test-waiters' #778

muziejus commented Apr 26, 2021 •

edited

angelayanpan commented Jan 5, 2022

ef4 commented Jan 5, 2022

angelayanpan commented Jan 5, 2022

angelayanpan commented Jan 5, 2022 •

edited

nightire commented Jan 6, 2022

angelayanpan commented Jan 6, 2022

ef4 commented Jan 7, 2022

angelayanpan commented Jan 11, 2022

bertdeblock commented Jan 11, 2022

angelayanpan commented Jan 11, 2022 •

edited

ef4 commented Jan 11, 2022

angelayanpan commented Jan 11, 2022 •

edited

rwjblue commented Jan 11, 2022

angelayanpan commented Jan 11, 2022

roomman commented Jan 18, 2022 •

edited

angelayanpan commented Jan 18, 2022

roomman commented Jan 18, 2022 •

edited

vfuto commented Jul 11, 2022

broccoliBuilderErrorStack … Can't resolve '../../test-waiters' #778

broccoliBuilderErrorStack … Can't resolve '../../test-waiters' #778

Comments

muziejus commented Apr 26, 2021 • edited

angelayanpan commented Jan 5, 2022

ef4 commented Jan 5, 2022

angelayanpan commented Jan 5, 2022

angelayanpan commented Jan 5, 2022 • edited

nightire commented Jan 6, 2022

angelayanpan commented Jan 6, 2022

ef4 commented Jan 7, 2022

angelayanpan commented Jan 11, 2022

bertdeblock commented Jan 11, 2022

angelayanpan commented Jan 11, 2022 • edited

ef4 commented Jan 11, 2022

angelayanpan commented Jan 11, 2022 • edited

rwjblue commented Jan 11, 2022

angelayanpan commented Jan 11, 2022

roomman commented Jan 18, 2022 • edited

angelayanpan commented Jan 18, 2022

roomman commented Jan 18, 2022 • edited

vfuto commented Jul 11, 2022

muziejus commented Apr 26, 2021 •

edited

angelayanpan commented Jan 5, 2022 •

edited

angelayanpan commented Jan 11, 2022 •

edited

angelayanpan commented Jan 11, 2022 •

edited

roomman commented Jan 18, 2022 •

edited

roomman commented Jan 18, 2022 •

edited