Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

WriteError return its argument as error status instead result of WriteErrorString #415

Closed
renkam opened this issue Oct 24, 2019 · 2 comments
Closed

WriteError return its argument as error status instead result of WriteErrorString #415

renkam opened this issue Oct 24, 2019 · 2 comments

Comments

@renkam
Copy link

renkam commented Oct 24, 2019

In function

go-restful/response.go

Line 178 in 5d8b667

func (r *Response) WriteError(httpStatus int, err error) error {
WriteError argument err is returned instead of result of calling WriteErrorString.
@emicklei
Copy link
Owner

good catch. this needs to be changed

emicklei added a commit that referenced this issue Oct 27, 2019
@emicklei
fix WriteError return value, issue #415
99f05a2
@emicklei
Copy link
Owner

emicklei commented Nov 4, 2019

i will close this as the fix has been pushed to master

@emicklei emicklei closed this as completed Nov 4, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@emicklei @renkam