Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add access to Route from Request, issue #459 #462

Merged
merged 2 commits into from Apr 10, 2021
Merged

add access to Route from Request, issue #459 #462

merged 2 commits into from Apr 10, 2021

Conversation

emicklei
Copy link
Owner

No description provided.

@codecov-io
Copy link

codecov-io commented Dec 13, 2020

Codecov Report

Merging #462 (133c27e) into v3 (ccd1b24) will decrease coverage by 0.05%.
The diff coverage is 66.66%.

Impacted file tree graph

@@            Coverage Diff             @@
##               v3     #462      +/-   ##
==========================================
- Coverage   71.33%   71.27%   -0.06%     
==========================================
  Files          25       25              
  Lines        1200     1201       +1     
==========================================
  Hits          856      856              
- Misses        274      275       +1     
  Partials       70       70              
Impacted Files Coverage Δ
request.go 70.27% <50.00%> (-1.96%) ⬇️
route.go 83.33% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ccd1b24...133c27e. Read the comment docs.

@Fapiko
Copy link

Fapiko commented Jan 12, 2021

Apologies - didn't see your previous comment. I think this would work perfectly!

@emicklei
Copy link
Owner Author

To control the access the the Route returned from the function, I am now working on a RouteReader interface.

@emicklei emicklei merged commit 83fd2c0 into v3 Apr 10, 2021
@emicklei emicklei deleted the meta-access branch April 10, 2021 11:28
emicklei added a commit that referenced this pull request Apr 10, 2021
* add access to Route from Request

* add RouteReader
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants