feat(extensions): adds vendor extensions to all entities #477
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Swagger provides vendor extensions that allow custom properties to be added to any of the swagger entities (params, operations, responses, etc...) Has interdependent changes with go-restful-openapi as well. See: https://swagger.io/docs/specification/2-0/swagger-extensions/
emicklei
reviewed
Sep 14, 2021
|
Thank you for contributing the making this last change. One last preference is to not use an abbreviation for ExtensionProperties. As you can see in the package, no other type name is shortened. |
Changes applied. Thanks for the prompt reviews 👍🏻 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Swagger provides vendor extensions that allow custom properties to be added to any of the swagger entities (params, operations, responses, etc...). This adds a new companion type:
restful.ExtensionPropsthat provides amap[string]interface{}to store extension values by their string key and theAddExtension(key string, value interface{})method to store values.Since swagger is handled by the
go-restful-openapimodule, the changes here are required in its own pull request: emicklei/go-restful-openapi#71For more details on swagger extensions, please see: https://swagger.io/docs/specification/2-0/swagger-extensions/