feat(parameter): adds additional openapi mappings #478
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Adds the following OpenAPI features to parameter: - AllowEmptyValue - Pattern - Minimum - Maximum - MinLength - MaxLength - MinItems - MaxItems - UniqueItems This has additional changes to go-restful-openapi that I will link after submitting to that repo.
SVilgelm
pushed a commit
to SVilgelm/go-restful
that referenced
this pull request
Nov 24, 2021
…et function The PR emicklei#478 brought some weird changes that breaks the filters behaviour. We have a filter that creates another instance of Response to intercept all headers and data, then does an audit and modifies the data and only then it forwards to the original response. But the lambda added in that PR breaks this logic, since the target function writes directly to the original response.
emicklei
pushed a commit
that referenced
this pull request
Nov 24, 2021
…et function (#482) The PR #478 brought some weird changes that breaks the filters behaviour. We have a filter that creates another instance of Response to intercept all headers and data, then does an audit and modifies the data and only then it forwards to the original response. But the lambda added in that PR breaks this logic, since the target function writes directly to the original response.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds the following OpenAPI features to parameter:
This also adds the operation name and route
ParameterDocsto theFilterChainstruct to allow filters access to both the operation name as well as the parameters defined for the requested route. Having this metadata allows filters to validate if a request is honoring the defined parameters.This has additional changes to emicklei/go-restful-openapi#74 that would need to also be merged and released after this is.