Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prediction? #5

Open
fizixes opened this issue Feb 7, 2024 · 2 comments
Open

Prediction? #5

fizixes opened this issue Feb 7, 2024 · 2 comments

Comments

@fizixes
Copy link

fizixes commented Feb 7, 2024

With relative ease I was able to modify it to accept a csv in a slightly altered format. I just don't understand where the prediction comes in, I can view the predicted results historically but I'm not sure where I'm looking for future results, is it just 1 value so I can't tell on the graph? Thanks!

@Cycxyz
Copy link

Cycxyz commented May 7, 2024

Looks like it simply uses price data to make prediction. In normalize_zero_base() you can see what's going on. If you print continuous.iloc[0] you'll see bunch of diffs, anything except date. So X_train and X_test he uses to predict price include that price. That's why his precision that good

@Cycxyz
Copy link

Cycxyz commented May 7, 2024

I really don't understand why it has so much stars. Looks like plain trick to impress someone or idk

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants