Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

React-redux incompatibility after upgrade to 10.0.4 #1099

Closed
rylek90 opened this issue Dec 12, 2018 · 2 comments
Closed

React-redux incompatibility after upgrade to 10.0.4 #1099

rylek90 opened this issue Dec 12, 2018 · 2 comments

Comments

@rylek90
Copy link

rylek90 commented Dec 12, 2018

  • emotion version: 10.0.4
  • react version: 16.6.3

What you did:
I've upgraded our codebase following the migration guide
I don't know, perhaps I did something wrong in here but code seems right

What happened:
react-redux started to throw circular structure serialization exceptions

Reproduction:
https://codesandbox.io/s/q4nj22j8jq

Suggested solution:
No idea, really... might be my problem and everything I need is only direction in good way 🤔

@Andarist
Copy link
Member

I've prepared a fix in react-redux - reduxjs/react-redux#1122

@Andarist
Copy link
Member

The react-redux PR got merged in, nothing to do more on emotion's side. You'll have to wait for their new release. In the meantime you can create a proxy component like this https://codesandbox.io/s/w02oj3xzq8

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants