Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Separate message type for when the destinationAccount needs to be sent #23

Open
emschwartz opened this issue Feb 28, 2018 · 2 comments
Open
Labels
protocol change Feature or bug that will require a protocol change

Comments

@emschwartz
Copy link
Owner

Currently, the data that goes across the wire for every chunk includes a spot for the destinationAccount. At the moment this is only used on the first message the client sends to the server, and is left as an empty string (encoded as a single 0-byte) for every subsequent message.

We should probably make a separate message type that has the destinationAccount field.

One question related to this is whether that message should be thought of as a "connect" message, or whether you could send that later, for example if you want to change the ILP address the other party should be sending to.

@emschwartz emschwartz added the protocol change Feature or bug that will require a protocol change label Feb 28, 2018
@sharafian
Copy link
Collaborator

we definitely want to retain the ability to change the account on an already established stream, so we shouldn't just put it as the connect message.

@emschwartz
Copy link
Owner Author

Agreed. Then the question is just whether we should have a different type that indicates whether there is an account in there or whether we should keep using the (somewhat hacky) trick of just putting the account as an empty string.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
protocol change Feature or bug that will require a protocol change
Projects
None yet
Development

No branches or pull requests

2 participants