Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[XRP] Lookup channels in parallel #16

Open
dappelt opened this issue Nov 29, 2017 · 0 comments
Open

[XRP] Lookup channels in parallel #16

dappelt opened this issue Nov 29, 2017 · 0 comments

Comments

@dappelt
Copy link
Collaborator

dappelt commented Nov 29, 2017

checkIfChannelsNeedToBeClaimed() checks sequentially if any of the connector's paychans need to be claimed. .getPaymentChannel() and .submit() are both awaited. I wonder how long these functions take to complete if RippleNet is under load. Are there any worst-case estimates?

Assuming that getPaymentChannel lookups take some time to complete, an attacker could open many paychans to the connector and make the connector forward a payment on the channel the connector looks up last. If the time to look up all the channels exceeds the settle delay, the connector will miss submitting the claim before the channel closes.

Solution: Lookup channels and submit claims in parallel. Also, a real connector probably wants to closely monitor RippleNet load and adapt accordingly.

@dappelt dappelt changed the title Lookup channels in parallel [XRP] Lookup channels in parallel Nov 29, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant