-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[XRP] Consider renaming channel.amount to channel.balance #17
Comments
My understanding of those two terms was basically the opposite (they're pretty poorly named). From the rippled docs:
That sounds to me like it would be the amount secured by the best claim... |
In parameters of the payment channel creation, |
In case the part "including XRP previously redeemed" is confusing to you, all that means is that |
The amount secured by the best claim is stored in channel.amount. However, in the context of XRP paychans,
amount
refers to the total funding in a channel and balance denotes how much was claimed out of the channel (see rippled and ripple-lib). To avoid confusions, it would be better to stick with the same terminology as rippled and ripple-lib.The text was updated successfully, but these errors were encountered: