Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Re-merge exec-wasmtime crates once Cargo supports multidep #1798

Closed
bstrie opened this issue Apr 28, 2022 · 1 comment · Fixed by #1847
Closed

Re-merge exec-wasmtime crates once Cargo supports multidep #1798

bstrie opened this issue Apr 28, 2022 · 1 comment · Fixed by #1847
Assignees
Labels
debt Issues to deal with later wasm Issues related to WebAssembly

Comments

@bstrie
Copy link
Contributor

bstrie commented Apr 28, 2022

In #1794 we split the exec-wasmtime crate out into separate library and binary crates. The motivation for this was to keep CI times from increasing; while the exec-wasmtime binary is a mandatory binary dependency (built for the linux-musl target), the exec-wasmtime library (built for the host's target) can be optional, which leads to noticeable build time wins since we can potentially avoid building the wasmtime crate twice. The long-term fix for this is a new Cargo feature called "multidep": rust-lang/cargo#10061 , which is an extension of binary dependency support ( #1445 ), which allows duplicate dependency declarations when binary dependencies are involved. Once that support lands, we can merge the exec's library and binary crates back together, and depend on it once as a normal optional dependency and once as a mandatory binary dependency with no problems.

@bstrie
Copy link
Contributor Author

bstrie commented Apr 28, 2022

Blocked on #1799 .

@haraldh haraldh added the wasm Issues related to WebAssembly label Apr 29, 2022
@platten platten added the debt Issues to deal with later label Apr 29, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
debt Issues to deal with later wasm Issues related to WebAssembly
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants