Support HTTPMethod for @api_view

[johnthagen]

The @action docs support using Python 3.11 HTTPMethod rather than bare strings.

Could this be extended to @api_view, where I think it would have similar use

• https://www.django-rest-framework.org/api-guide/views/#api_view

@api_view([HTTPMethod.GET, HTTPMethod.POST])
def hello_world(request):
    if request.method == HTTPMethod.POST:
        ...

Related to

• Python 3.11, support new http.HTTPMethod enum in action and view #8995

[tomchristie]

I think it should either be documented / supported in both places or neither.

Personally I'd probably suggest the second, and dropping it from the API docs. No problem with folks using the HTTPMethod.GET style if they want to use that enum, but there's probably a whole lot of places we could be switching documentation around if we start taking that approach.

(That'd be my first take anyways... ?)

[tomchristie]

Okay, well let's start with this...

Could this be extended to @api_view, where I think it would have similar use

Does HTTPMethod.GET currently work for api_view?

[johnthagen]

I haven't tried since I don't know if that is a supported/intended use case. In the case of #8995, tests were required to ensure that it is in fact supported and does not regress

• https://github.com/encode/django-rest-framework/pull/9067/files

[auvipy]

It would be great if you come with some test case atleast....

[johnthagen]

@tomchristie

Does HTTPMethod.GET currently work for api_view?

I replaced bare str literals (included examples with "GET", "PATCH", and "POST") with HTTPMethod across 6 api_views in my DRF application. My entire unit test suite passed and the OpenAPI schema generated by drf-spectacular remained unchanged.

So it appears that this works currently.

It would be great if you come with some test case atleast....

Sorry, based on the discussion I wasn't sure if this was even something desired by the DRF maintainers.

[tomchristie]

Thanks @johnthagen. It's a perfectly reasonable question.
I'm not that keen on it myself.

Probably a more comprehensive question here is where are all the cases of using HTTP methods as string literals (throughout) and are all the cases where we use them as string literals case insensitive or not?