Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: encode/httpcore
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: 1.0.1
Choose a base ref
...
head repository: encode/httpcore
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: 1.0.2
Choose a head ref
  • 3 commits
  • 4 files changed
  • 3 contributors

Commits on Nov 8, 2023

  1. Fix float("inf") timeouts (#846)

    * Fix float timeouts in synchronous event
    
    * Changelog
    karpetrosyan authored Nov 8, 2023

    Verified

    This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
    Copy the full SHA
    1e7597b View commit details
  2. Bump ruff from 0.0.291 to 0.1.3 (#834)

    Bumps [ruff](https://github.com/astral-sh/ruff) from 0.0.291 to 0.1.3.
    - [Release notes](https://github.com/astral-sh/ruff/releases)
    - [Changelog](https://github.com/astral-sh/ruff/blob/main/CHANGELOG.md)
    - [Commits](astral-sh/ruff@v0.0.291...v0.1.3)
    
    ---
    updated-dependencies:
    - dependency-name: ruff
      dependency-type: direct:production
      update-type: version-update:semver-minor
    ...
    
    Signed-off-by: dependabot[bot] <support@github.com>
    Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
    Co-authored-by: Tom Christie <tom@tomchristie.com>
    dependabot[bot] and tomchristie authored Nov 8, 2023

    Verified

    This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
    Copy the full SHA
    8c03a6a View commit details

Commits on Nov 10, 2023

  1. Version 1.0.2 (#847)

    * Version 1.0.2
    
    * Update CHANGELOG.md
    
    ---------
    
    Co-authored-by: Tom Christie <tom@tomchristie.com>
    karpetrosyan and tomchristie authored Nov 10, 2023

    Verified

    This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
    Copy the full SHA
    0d2c93c View commit details
Showing with 8 additions and 2 deletions.
  1. +4 −0 CHANGELOG.md
  2. +1 −1 httpcore/__init__.py
  3. +2 −0 httpcore/_synchronization.py
  4. +1 −1 requirements.txt
4 changes: 4 additions & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
@@ -4,6 +4,10 @@ All notable changes to this project will be documented in this file.

The format is based on [Keep a Changelog](https://keepachangelog.com/en/1.0.0/).

## 1.0.2 (November 10th, 2023)

- Fix `float("inf")` timeouts in `Event.wait` function. (#846)

## 1.0.1 (November 3rd, 2023)

- Fix pool timeout to account for the total time spent retrying. (#823)
2 changes: 1 addition & 1 deletion httpcore/__init__.py
Original file line number Diff line number Diff line change
@@ -130,7 +130,7 @@ def __init__(self, *args, **kwargs): # type: ignore
"WriteError",
]

__version__ = "1.0.1"
__version__ = "1.0.2"


__locals = locals()
2 changes: 2 additions & 0 deletions httpcore/_synchronization.py
Original file line number Diff line number Diff line change
@@ -226,6 +226,8 @@ def set(self) -> None:
self._event.set()

def wait(self, timeout: Optional[float] = None) -> None:
if timeout == float("inf"): # pragma: no cover
timeout = None
if not self._event.wait(timeout=timeout):
raise PoolTimeout() # pragma: nocover

2 changes: 1 addition & 1 deletion requirements.txt
Original file line number Diff line number Diff line change
@@ -15,7 +15,7 @@ twine
# Tests & Linting
black==23.10.1
coverage[toml]==7.3.0
ruff==0.0.291
ruff==0.1.3
mypy==1.5.1
trio-typing==0.9.0
types-certifi==2021.10.8.3