Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't always encode forward slashes as %2F in query parameters #2864

Closed
scnerd opened this issue Sep 27, 2023 · 2 comments
Closed

Don't always encode forward slashes as %2F in query parameters #2864

scnerd opened this issue Sep 27, 2023 · 2 comments

Comments

@scnerd
Copy link

scnerd commented Sep 27, 2023

#2723 Transitions to encoding "/" as "%2F" in the query; the argument is that this is "more correct" and more inline with browsers' default behavior.

The problem is that some API's simply reject this; for them, the two encodings are not identical. A comment on #2721 remarks that the OpenAI API expects actual slashes. I'm dealing with a private backend (that I don't control) that likewise expects actual slashes.

This new behavior should be possible to opt out of.

@thetanz-geoff
Copy link

@scnerd: This is raised in discussions (per the rules: "Please only raise an issue if you've been advised to do so after discussion.") here:
#2856
#2863

Suggest you keep an eye on all 3 threads for a response, and downgrade to 0.24.1 in the interim.

@zanieb
Copy link
Contributor

zanieb commented Sep 29, 2023

Closing in favor of the existing discussions for now.

@zanieb zanieb closed this as not planned Won't fix, can't repro, duplicate, stale Sep 29, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants