{"payload":{"feedbackUrl":"https://github.com/orgs/community/discussions/53140","repo":{"id":13224558,"defaultBranch":"master","name":"eos-event-recorder-daemon","ownerLogin":"endlessm","currentUserCanPush":false,"isFork":false,"isEmpty":false,"createdAt":"2013-09-30T19:14:11.000Z","ownerAvatar":"https://avatars.githubusercontent.com/u/1930958?v=4","public":true,"private":false,"isOrgOwned":true},"refInfo":{"name":"","listCacheKey":"v0:1715695375.0","currentOid":""},"activityList":{"items":[{"before":"2337d4d46112cff81ed406d8fb4adfc9b737657f","after":"5101c7d1acef9b013ad8566bd2d708db3ce57d2a","ref":"refs/heads/eos6.0","pushedAt":"2024-05-03T16:42:25.000Z","pushType":"push","commitsCount":13,"pusher":{"login":"wjt","name":"Will Thompson","path":"/wjt","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/86760?s=80&v=4"},"commit":{"message":"Merge pull request #299 from endlessm/T35331-install-inspection-tools\n\nInstall tools to inspect local metrics caches","shortMessageHtmlLink":"Merge pull request #299 from endlessm/T35331-install-inspection-tools"}},{"before":"80a92512fab4b5ee10508506f825c19c52089843","after":null,"ref":"refs/heads/T35331-install-inspection-tools","pushedAt":"2024-05-01T12:54:35.000Z","pushType":"branch_deletion","commitsCount":0,"pusher":{"login":"wjt","name":"Will Thompson","path":"/wjt","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/86760?s=80&v=4"}},{"before":"6b7ab4dd18f9bd5393085528e653edc99bad838d","after":"5101c7d1acef9b013ad8566bd2d708db3ce57d2a","ref":"refs/heads/master","pushedAt":"2024-05-01T12:54:34.000Z","pushType":"pr_merge","commitsCount":3,"pusher":{"login":"wjt","name":"Will Thompson","path":"/wjt","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/86760?s=80&v=4"},"commit":{"message":"Merge pull request #299 from endlessm/T35331-install-inspection-tools\n\nInstall tools to inspect local metrics caches","shortMessageHtmlLink":"Merge pull request #299 from endlessm/T35331-install-inspection-tools"}},{"before":null,"after":"80a92512fab4b5ee10508506f825c19c52089843","ref":"refs/heads/T35331-install-inspection-tools","pushedAt":"2024-04-30T16:24:11.000Z","pushType":"branch_creation","commitsCount":0,"pusher":{"login":"wjt","name":"Will Thompson","path":"/wjt","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/86760?s=80&v=4"},"commit":{"message":"tools: Fix print-aggregates’ description\n\nhttps://phabricator.endlessm.com/T35331","shortMessageHtmlLink":"tools: Fix print-aggregates’ description"}},{"before":"6dbac4bee8196ab89f3876e1256c41b71cdd214d","after":null,"ref":"refs/heads/T35331-print-aggregates","pushedAt":"2024-04-26T06:29:28.000Z","pushType":"branch_deletion","commitsCount":0,"pusher":{"login":"wjt","name":"Will Thompson","path":"/wjt","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/86760?s=80&v=4"}},{"before":null,"after":"6dbac4bee8196ab89f3876e1256c41b71cdd214d","ref":"refs/heads/T35331-print-aggregates","pushedAt":"2024-04-26T06:29:26.000Z","pushType":"branch_creation","commitsCount":0,"pusher":{"login":"wjt","name":"Will Thompson","path":"/wjt","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/86760?s=80&v=4"},"commit":{"message":"aggregate-tally: Remove ability to stop iteration\n\nPreviously, the callback passed to emer_aggregate_tally_iter() or\nemer_aggregate_tally_iter_before() would return a value from the\nEmerTallyIterResult enum, either CONTINUE or STOP. The iteration logic\nwould stop iteration if the callback returned STOP. (Actually it\nperformed a bitwise comparison, but since the only documented values\nwere 0 or 1 it's the same thing.)\n\nThis functionality is unused, and has been broken since commit\nc56d656ea46176ecd405a0ba4f1ed93ed21cdd27. In the case where the loop\nwas terminated early by the callback, 'ret' would still hold SQLITE_ROW,\nwhich would then be passed to our check_sqlite_error() helper (via the\nCHECK() macro). This macro considers any value other than SQLITE_OK or\nSQLITE_DONE to be an error.\n\nRather than try to fix it, we can just remove it without loss of\nfunctionality.\n\nhttps://phabricator.endlessm.com/T35331","shortMessageHtmlLink":"aggregate-tally: Remove ability to stop iteration"}},{"before":"6dbac4bee8196ab89f3876e1256c41b71cdd214d","after":null,"ref":"refs/heads/T35331-print-aggregates","pushedAt":"2024-04-26T06:29:24.000Z","pushType":"branch_deletion","commitsCount":0,"pusher":{"login":"wjt","name":"Will Thompson","path":"/wjt","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/86760?s=80&v=4"}},{"before":"2337d4d46112cff81ed406d8fb4adfc9b737657f","after":"6b7ab4dd18f9bd5393085528e653edc99bad838d","ref":"refs/heads/master","pushedAt":"2024-04-26T06:29:23.000Z","pushType":"pr_merge","commitsCount":10,"pusher":{"login":"wjt","name":"Will Thompson","path":"/wjt","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/86760?s=80&v=4"},"commit":{"message":"Merge pull request #298 from endlessm/T35331-print-aggregates\n\nAdd a tool to print buffered aggregates to the CLI","shortMessageHtmlLink":"Merge pull request #298 from endlessm/T35331-print-aggregates"}},{"before":"fb59b76f8199dd53234520027a1f867614b302f9","after":"6dbac4bee8196ab89f3876e1256c41b71cdd214d","ref":"refs/heads/T35331-print-aggregates","pushedAt":"2024-04-25T14:29:29.000Z","pushType":"force_push","commitsCount":0,"pusher":{"login":"wjt","name":"Will Thompson","path":"/wjt","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/86760?s=80&v=4"},"commit":{"message":"aggregate-tally: Remove ability to stop iteration\n\nPreviously, the callback passed to emer_aggregate_tally_iter() or\nemer_aggregate_tally_iter_before() would return a value from the\nEmerTallyIterResult enum, either CONTINUE or STOP. The iteration logic\nwould stop iteration if the callback returned STOP. (Actually it\nperformed a bitwise comparison, but since the only documented values\nwere 0 or 1 it's the same thing.)\n\nThis functionality is unused, and has been broken since commit\nc56d656ea46176ecd405a0ba4f1ed93ed21cdd27. In the case where the loop\nwas terminated early by the callback, 'ret' would still hold SQLITE_ROW,\nwhich would then be passed to our check_sqlite_error() helper (via the\nCHECK() macro). This macro considers any value other than SQLITE_OK or\nSQLITE_DONE to be an error.\n\nRather than try to fix it, we can just remove it without loss of\nfunctionality.\n\nhttps://phabricator.endlessm.com/T35331","shortMessageHtmlLink":"aggregate-tally: Remove ability to stop iteration"}},{"before":"849669b877a70b25c2b1558d765c14105f0bdaa3","after":"fb59b76f8199dd53234520027a1f867614b302f9","ref":"refs/heads/T35331-print-aggregates","pushedAt":"2024-04-19T19:07:06.000Z","pushType":"force_push","commitsCount":0,"pusher":{"login":"wjt","name":"Will Thompson","path":"/wjt","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/86760?s=80&v=4"},"commit":{"message":"aggregate-tally: Stop deleting old database path\n\nThis (effectively) reverts commit\na0130025eaf6dd8eb4ba1fc0e2b93722fe3c05fd. It's been more than 2 years.\n\nhttps://phabricator.endlessm.com/T35331","shortMessageHtmlLink":"aggregate-tally: Stop deleting old database path"}},{"before":"add638be2cea497bba308962be42e63054e483f1","after":"849669b877a70b25c2b1558d765c14105f0bdaa3","ref":"refs/heads/T35331-print-aggregates","pushedAt":"2024-04-19T18:54:21.000Z","pushType":"force_push","commitsCount":0,"pusher":{"login":"wjt","name":"Will Thompson","path":"/wjt","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/86760?s=80&v=4"},"commit":{"message":"aggregate-tally: Propagate errors while iterating\n\nPreviously emer_aggregate_tally_iter() and\nemer_aggregate_tally_iter_before() had no return value and would simply\ncall g_warning() in the error case. This makes it hard to test the error\npaths without aborting the test program.\n\nMake each function return an error and move the g_warning() out into the\ncalling functions.\n\nhttps://phabricator.endlessm.com/T35331","shortMessageHtmlLink":"aggregate-tally: Propagate errors while iterating"}},{"before":"aa60c72f7b19e0e4aa133232bb36f6de1d21983b","after":"add638be2cea497bba308962be42e63054e483f1","ref":"refs/heads/T35331-print-aggregates","pushedAt":"2024-04-19T18:45:30.000Z","pushType":"force_push","commitsCount":0,"pusher":{"login":"wjt","name":"Will Thompson","path":"/wjt","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/86760?s=80&v=4"},"commit":{"message":"aggregate-tally: Propagate errors while iterating\n\nPreviously emer_aggregate_tally_iter() and\nemer_aggregate_tally_iter_before() had no return value and would simply\ncall g_warning() in the error case. This makes it hard to test the error\npaths without aborting the test program.\n\nMake each function return an error and move the g_warning() out into the\ncalling functions.\n\nhttps://phabricator.endlessm.com/T35331","shortMessageHtmlLink":"aggregate-tally: Propagate errors while iterating"}},{"before":null,"after":"aa60c72f7b19e0e4aa133232bb36f6de1d21983b","ref":"refs/heads/T35331-print-aggregates","pushedAt":"2024-04-19T15:34:28.000Z","pushType":"branch_creation","commitsCount":0,"pusher":{"login":"wjt","name":"Will Thompson","path":"/wjt","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/86760?s=80&v=4"},"commit":{"message":"aggregate-tally: Remove unnecessary sqlite3_reset() call\n\nsqlite3_reset() is only useful to re-execute the same prepared\nstatement. There is no need to call it when we are just about to destroy\nthe statement with sqlite3_finalize() anyway.\n\nhttps://phabricator.endlessm.com/T35331","shortMessageHtmlLink":"aggregate-tally: Remove unnecessary sqlite3_reset() call"}},{"before":null,"after":"2337d4d46112cff81ed406d8fb4adfc9b737657f","ref":"refs/heads/eos6.0","pushedAt":"2024-04-03T08:33:40.000Z","pushType":"branch_creation","commitsCount":0,"pusher":{"login":"eos-shell-build","name":null,"path":"/eos-shell-build","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/4185042?s=80&v=4"},"commit":{"message":"Merge pull request #297 from endlessm/T35165-fix-default-server-URL\n\nFix expanding default server URI","shortMessageHtmlLink":"Merge pull request #297 from endlessm/T35165-fix-default-server-URL"}},{"before":"f0e91f9cb84aeed7bcc93dfbb9b351ea396c142a","after":null,"ref":"refs/heads/T35165-fix-default-server-URL","pushedAt":"2024-01-18T09:29:04.000Z","pushType":"branch_deletion","commitsCount":0,"pusher":{"login":"wjt","name":"Will Thompson","path":"/wjt","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/86760?s=80&v=4"}},{"before":"d57cd624e8902deec30c2b1d23af4c7f4eda9fe7","after":"2337d4d46112cff81ed406d8fb4adfc9b737657f","ref":"refs/heads/master","pushedAt":"2024-01-18T09:29:03.000Z","pushType":"pr_merge","commitsCount":16,"pusher":{"login":"wjt","name":"Will Thompson","path":"/wjt","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/86760?s=80&v=4"},"commit":{"message":"Merge pull request #297 from endlessm/T35165-fix-default-server-URL\n\nFix expanding default server URI","shortMessageHtmlLink":"Merge pull request #297 from endlessm/T35165-fix-default-server-URL"}},{"before":"f26ab24b74f7757a42a402b02c650ab4e442fdfb","after":"f0e91f9cb84aeed7bcc93dfbb9b351ea396c142a","ref":"refs/heads/T35165-fix-default-server-URL","pushedAt":"2024-01-16T14:53:45.000Z","pushType":"force_push","commitsCount":0,"pusher":{"login":"wjt","name":"Will Thompson","path":"/wjt","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/86760?s=80&v=4"},"commit":{"message":"daemon: Disconnect signal handler on dispose\n\nEmerDaemon listens for change notifications on\nEmerPermissionsProvider:daemon-enabled. Previously, it never\ndisconnected this signal handler. In normal usage this is not a problem\nbecause the EmerPermissionsProvider is not reused for a different\nEmerDaemon instance. However, in the test suite it is. This manifested\nitself as non-deterministic segfaults.\n\nAdd an assertion that makes the failure deterministic. Use\ng_signal_connect_object() to automatically disconnect the signal handler\nwhen the EmerDaemon object is disposed. Depend on GLib 2.74 for the\nG_CONNECT_DEFAULT constant, which is just a self-documenting way of\nwriting the number 0.\n\nhttps://phabricator.endlessm.com/T35165","shortMessageHtmlLink":"daemon: Disconnect signal handler on dispose"}},{"before":"d70268c4169f6ef06cac2b192f39479945cd9975","after":"f26ab24b74f7757a42a402b02c650ab4e442fdfb","ref":"refs/heads/T35165-fix-default-server-URL","pushedAt":"2024-01-16T14:29:31.000Z","pushType":"push","commitsCount":2,"pusher":{"login":"wjt","name":"Will Thompson","path":"/wjt","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/86760?s=80&v=4"},"commit":{"message":"daemon: Disconnect signal handler on dispose\n\nEmerDaemon listens for change notifications on\nEmerPermissionsProvider:daemon-enabled. Previously, it never\ndisconnected this signal handler. In normal usage this is not a problem\nbecause the EmerPermissionsProvider is not reused for a different\nEmerDaemon instance. However, in the test suite it is. This manifested\nitself as non-deterministic segfaults.\n\nAdd an assertion that makes the failure deterministic. Use\ng_signal_connect_object() to automatically disconnect the signal handler\nwhen the EmerDaemon object is disposed. Depend on GLib 2.74 for the\nG_CONNECT_DEFAULT constant, which is just a self-documenting way of\nwriting the number 0.\n\nhttps://phabricator.endlessm.com/T35165","shortMessageHtmlLink":"daemon: Disconnect signal handler on dispose"}},{"before":"cea6ab30ae28b1277cbdc7287146f596580f09da","after":"d70268c4169f6ef06cac2b192f39479945cd9975","ref":"refs/heads/T35165-fix-default-server-URL","pushedAt":"2024-01-16T14:01:50.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"wjt","name":"Will Thompson","path":"/wjt","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/86760?s=80&v=4"},"commit":{"message":"ci: Print error logs from tests\n\nhttps://phabricator.endlessm.com/T35165","shortMessageHtmlLink":"ci: Print error logs from tests"}},{"before":"6cafa661cc9de8389f8f4f74a27c793a33332cd7","after":"cea6ab30ae28b1277cbdc7287146f596580f09da","ref":"refs/heads/T35165-fix-default-server-URL","pushedAt":"2024-01-16T13:56:02.000Z","pushType":"force_push","commitsCount":0,"pusher":{"login":"wjt","name":"Will Thompson","path":"/wjt","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/86760?s=80&v=4"},"commit":{"message":"meson: Use ExternalProgram.full_path()\n\nMeson 0.55 deprecated ExternalProgram.path() in favour of a new\nfunction, ExternalProgram.full_path(). The two functions are identical\nin behaviour, but Meson logs a \"future-deprecated\" warning if you use\n.path(). The renaming is not explained in the deprecation message or\ndocumentation, but appears to be solely for consistency with other\nobjects.\n\nDepend on a new-enough Meson for the new .full_path() method, and use\nit.\n\nhttps://phabricator.endlessm.com/T35165","shortMessageHtmlLink":"meson: Use ExternalProgram.full_path()"}},{"before":"ec1b19b587c71410fdbfa7198759b53e47ac2845","after":"6cafa661cc9de8389f8f4f74a27c793a33332cd7","ref":"refs/heads/T35165-fix-default-server-URL","pushedAt":"2024-01-15T16:56:56.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"wjt","name":"Will Thompson","path":"/wjt","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/86760?s=80&v=4"},"commit":{"message":"permission-provider: Use g_auto*\n\nhttps://phabricator.endlessm.com/T35165","shortMessageHtmlLink":"permission-provider: Use g_auto*"}},{"before":null,"after":"ec1b19b587c71410fdbfa7198759b53e47ac2845","ref":"refs/heads/T35165-fix-default-server-URL","pushedAt":"2024-01-15T16:50:14.000Z","pushType":"branch_creation","commitsCount":0,"pusher":{"login":"wjt","name":"Will Thompson","path":"/wjt","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/86760?s=80&v=4"},"commit":{"message":"Test expanding server URL template","shortMessageHtmlLink":"Test expanding server URL template"}},{"before":"078c83f2d8f958ddb5355644acddd8fee8177c04","after":"d57cd624e8902deec30c2b1d23af4c7f4eda9fe7","ref":"refs/heads/master","pushedAt":"2024-01-11T11:35:58.000Z","pushType":"pr_merge","commitsCount":8,"pusher":{"login":"wjt","name":"Will Thompson","path":"/wjt","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/86760?s=80&v=4"},"commit":{"message":"Merge pull request #296 from kalev/add-server-uri-to-config-file\n\nMake the server URI configurable in the config file","shortMessageHtmlLink":"Merge pull request #296 from kalev/add-server-uri-to-config-file"}},{"before":"483198cfa5f59d653d53359c63ae76f5d673da77","after":null,"ref":"refs/heads/T32203-1","pushedAt":"2024-01-10T14:54:49.000Z","pushType":"branch_deletion","commitsCount":0,"pusher":{"login":"wjt","name":"Will Thompson","path":"/wjt","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/86760?s=80&v=4"}},{"before":null,"after":"078c83f2d8f958ddb5355644acddd8fee8177c04","ref":"refs/heads/eos5.1","pushedAt":"2023-11-17T17:22:05.000Z","pushType":"branch_creation","commitsCount":0,"pusher":{"login":"eos-shell-build","name":null,"path":"/eos-shell-build","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/4185042?s=80&v=4"},"commit":{"message":"Merge pull request #295 from kalev/image-version-criticals\n\ndaemon: Avoid criticals on non-EOS where image version isn't set","shortMessageHtmlLink":"Merge pull request #295 from kalev/image-version-criticals"}},{"before":"0e2f248dbedaaadeadf76c3b369a45a669c8983b","after":"078c83f2d8f958ddb5355644acddd8fee8177c04","ref":"refs/heads/master","pushedAt":"2023-03-22T17:20:04.000Z","pushType":"pr_merge","commitsCount":2,"pusher":{"login":"wjt","name":"Will Thompson","path":"/wjt","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/86760?s=80&v=4"},"commit":{"message":"Merge pull request #295 from kalev/image-version-criticals\n\ndaemon: Avoid criticals on non-EOS where image version isn't set","shortMessageHtmlLink":"Merge pull request #295 from kalev/image-version-criticals"}}],"hasNextPage":false,"hasPreviousPage":false,"activityType":"all","actor":null,"timePeriod":"all","sort":"DESC","perPage":30,"cursor":"djE6ks8AAAAEQPILGQA","startCursor":null,"endCursor":null}},"title":"Activity · endlessm/eos-event-recorder-daemon"}