New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
util.merge breaks Proxies #390
Comments
Doesn't spreading also deference an object? |
if the obj itself is a proxy, sure, but if the object has attirbutes that point to Proxy objects, then they're preserved, unlike util.merge implementation |
Okay, that makes sense. I use proxies myself, so I appreciate this point. Want to do a PR? |
so I cloned it, did a test, banged my head a few times because it worked perfectly, then... it turns out it was already fixed in #308 .... however... which was fixed 2 years ago... |
Is there any reason for util.merge to simply not use
{...obj1,...obj2}
?The text was updated successfully, but these errors were encountered: