(1.0 . to BigDecimal) != 1.0 - e.g. equality isn't working correctly

[JaroslavTulach]

The support for non-builtin number types (as introduced by #8779) doesn't work well with ==. As result of that certain tests had to be disabled. This is a follow up issue that tracks further work on the reimplementation of EqualsNode.

The initial idea:

• when comparing two objects of different type, check possible conversions first
• only then use comparators

Catch:

• warn when there is not a consistency of hash code!

[Akirathan]

After #7883, the consistency of hash code can be checked within Runtime.assert. That way, we ensure that the hash consistency is checked only in tests and not in production.

[enso-bot]

Jaroslav Tulach reports a new STANDUP for yesterday (2024-02-14):

Progress: - meetings

• working on Big_Decimal and its equality It should be finished by 2024-02-19.

Next Day: equality in Big_Decimal

[enso-bot]

Jaroslav Tulach reports a new STANDUP for yesterday (2024-02-15):

Progress: Feb 15 - 10 h
- drat PR for Equality with conversions: #9070
- EqualsNode.DoThatConvertionNode: a214c0b
- assert hash & == consistency: https://github.com/enso-org/enso/pull/9070/files#r1491152185
- benchmarks regression: #9070 (comment)
- flaw detected: #9070 (comment)
- testing serialization fix: #9057 (comment)
- bookclubbing attempt: https://discord.com/channels/401396655599124480/1207372697278087208/1207621991641915473
- preparing GeeCON abstract: https://docs.google.com/document/d/1vvTlKbDyFQHr6y2uE36bhHjcbXo_zhOWkos8m8zds_M
- discussion about CI: https://discord.com/channels/@me/961191821969596426/1207723602691227688
- emails, reviews It should be finished by 2024-02-19.

Next Day: equality in Big_Decimal

GitHub

Equality with conversions by JaroslavTulach · Pull Request #9070 · enso-org/enso

Pull Request Description Fixes #8855 by providing support for == between different types with conversions. Checklist Please ensure that the following checklist has been satisfied before submitting ...

Discord

Discord - A New Way to Chat with Friends & Communities

Discord is the easiest way to communicate over voice, video, and text. Chat, hang out, and stay close with your friends and communities.

Discord

Discord - A New Way to Chat with Friends & Communities

Discord is the easiest way to communicate over voice, video, and text. Chat, hang out, and stay close with your friends and communities.

[enso-bot]

Jaroslav Tulach reports a new STANDUP for yesterday (2024-02-16):

Progress: - Explictly Both Comparators: #9070 (comment)

• Review colleasing of visualizations: Keep single execute expression job in the queue #9077 (review)
• initial implementation a5c0674
• benchmarks are fine: Equality with conversions #9070 (comment)
• fixed (upon hint) the VSCode extension failure: ActionProvider and its Lookup in NbLaunchDelegate apache/netbeans#7059 (comment)
• discussing CI with Michal It should be finished by 2024-02-19.

Next Day: testing & documenting equality in Big_Decimal

[enso-bot]

Jaroslav Tulach reports a new STANDUP for the last Saturday (2024-02-17):

Progress: - BigDecimal & hash discussion: https://discord.com/channels/@me/948519891961544714/1208273876241485885

• equalities test: 145fc55
• benchmark with conversion: 1d16e40
• analyzing IGV graphs It should be finished by 2024-02-19.

Next Day: integrate equality in Big_Decimal

Discord

Discord - A New Way to Chat with Friends & Communities

Discord is the easiest way to communicate over voice, video, and text. Chat, hang out, and stay close with your friends and communities.

[enso-bot]

Jaroslav Tulach reports a new STANDUP for yesterday (2024-02-19):

Progress: - documenting & integrated ==: #9070

• review semver: Drop inefficient SemVer implementation #9089 (review)
• Playing with IGV + bugfix: Less indented (but full) stacktrace in IGV oracle/graal#8405
• more of IGV
• discussing project loom and JSON parsing
• meetings It should be finished by 2024-02-19.

Next Day: Planning next big thing...