Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow copying of text from errors and warnings #9878

Closed
AdRiley opened this issue May 7, 2024 · 4 comments · Fixed by #10023
Closed

Allow copying of text from errors and warnings #9878

AdRiley opened this issue May 7, 2024 · 4 comments · Fixed by #10023
Assignees
Labels
-gui d-easy Difficulty: little prior knowledge required p-high Should be completed in the next sprint x-new-feature Type: new feature request
Milestone

Comments

@AdRiley
Copy link
Member

AdRiley commented May 7, 2024

When you get an error:
There isn't an easy way to get the text for copy/paste for reporting the isssue.

image

Can we allow the selection and copying of the text?
Right click -> copy menu?

@AdRiley AdRiley added x-new-feature Type: new feature request -gui labels May 7, 2024
@AdRiley AdRiley added this to the Beta Release milestone May 7, 2024
@farmaazon farmaazon added d-easy Difficulty: little prior knowledge required p-medium Should be completed in the next few sprints labels May 9, 2024
@farmaazon
Copy link
Contributor

  • Enable text selecting and context menu in the error message.
  • We can check what options are in context menu and configure electron to adjust it (remove entries like "Print" or "Inspect").

@farmaazon farmaazon added p-high Should be completed in the next sprint and removed p-medium Should be completed in the next few sprints labels May 9, 2024
@vitvakatu vitvakatu self-assigned this May 17, 2024
@vitvakatu vitvakatu mentioned this issue May 17, 2024
4 tasks
@vitvakatu
Copy link
Contributor

vitvakatu commented May 17, 2024

We significantly underestimated this task.

  • Enabling selection for text is easy, but it conflicts with the node output port. Selecting text without using the triple-click can be difficult.
  • Electron does not provide us with a ready-to-use context menu! We don’t have it because it is not offered, not because we disable it.
  • There is a library for Electron called electron-context-menu that provides basic customizable context menu. But it requires Electron 30 or above. We’re on version 25 right now.
    I was able to write code that opens a native context menu on right-click in the app, but I still need to implement actual text copying. I’m not sure I understand how exactly it should work.
  • Besides, the context menu conflicts with the navigator now – the right click is used there for zooming.

WIP code is available in #9988

@enso-bot
Copy link

enso-bot bot commented May 18, 2024

Ilya Bogdanov reports a new STANDUP for the provided date (2024-05-17):

Progress: Started the implementation but quickly ran into problems. Opened a draft PR and described my findings. It should be finished by 2024-05-30.

@farmaazon farmaazon self-assigned this May 20, 2024
@farmaazon
Copy link
Contributor

Because the previous approach would require some designing, we decided to, for now, create a button for copying entire message.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
-gui d-easy Difficulty: little prior knowledge required p-high Should be completed in the next sprint x-new-feature Type: new feature request
Projects
Status: 🟢 Accepted
Development

Successfully merging a pull request may close this issue.

4 participants