Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move to the Tab layout for Dashboard #9918

Open
wants to merge 63 commits into
base: develop
Choose a base branch
from

Conversation

somebody1234
Copy link
Collaborator

@somebody1234 somebody1234 commented May 10, 2024

Pull Request Description

⚠️ This PR depends on #9896 and MUST NOT be merged before that one.

  • Close Move to the Tab layout for Dashboard #9898
    • Move right menu to Drive View
      • Use new icon for toggling the menu
    • Move Search Bar into Drive View
      • both of these changes come with free simplifications to the code.
    • Refactor entire Top Bar to show pages as tabs

Important Notes

  • Fonts containing slight variants have been added to make it match more closely with the Figma design. HOWEVER:
    • They have been added in app/gui2 instead of the Dashboard codebase, because that is where the existing Enso font is located.
      • While it's definitely possible to put them in the Dashboard codebase, I think it's preferable to avoid that, otherwise we will have two separate mechanisms for loading/packaging fonts.
    • However, this problem SHOULD go away if (if not when) the entrypoints for the desktop app (in app/gui2) and cloud.enso.org (in app/ide-desktop/lib/dashboard) are merged.

Screencast

dashboard-tabs.mp4

Checklist

Please ensure that the following checklist has been satisfied before submitting the PR:

  • The documentation has been updated, if necessary.
  • Screenshots/screencasts have been attached, if there are any visual changes. For interactive or animated visual changes, a screencast is preferred.
  • All code follows the
    Scala,
    Java,
    TypeScript,
    and
    Rust
    style guides. In case you are using a language not listed above, follow the Rust style guide.
  • Unit tests have been written where possible.

@somebody1234 somebody1234 added CI: No changelog needed Do not require a changelog entry for this PR. x-new-feature Type: new feature request g-dashboard labels May 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CI: No changelog needed Do not require a changelog entry for this PR. g-dashboard x-new-feature Type: new feature request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Move to the Tab layout for Dashboard
3 participants